Skip to content

Commit ab78baf

Browse files
authored
Markers - Better fix for microsoft#156186 (microsoft#159180)
Better fix for microsoft#156186
1 parent 150dbe4 commit ab78baf

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

src/vs/platform/markers/common/markerService.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -200,10 +200,6 @@ export class MarkerService implements IMarkerService {
200200
tags,
201201
} = data;
202202

203-
if (unsupportedSchemas.has(resource.scheme)) {
204-
return undefined;
205-
}
206-
207203
if (!message) {
208204
return undefined;
209205
}

src/vs/workbench/contrib/markers/browser/markersModel.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import { Hasher } from 'vs/base/common/hash';
1414
import { withUndefinedAsNull } from 'vs/base/common/types';
1515
import { splitLines } from 'vs/base/common/strings';
1616
import { IMatch } from 'vs/base/common/filters';
17+
import { unsupportedSchemas } from 'vs/platform/markers/common/markerService';
1718

1819
export type MarkerElement = ResourceMarkers | Marker | RelatedInformation;
1920

@@ -189,6 +190,10 @@ export class MarkersModel {
189190
const change: MarkerChangesEvent = { added: new Set(), removed: new Set(), updated: new Set() };
190191
for (const [resource, rawMarkers] of resourcesMarkers) {
191192

193+
if (unsupportedSchemas.has(resource.scheme)) {
194+
continue;
195+
}
196+
192197
const key = extUri.getComparisonKey(resource, true);
193198
let resourceMarkers = this.resourcesByUri.get(key);
194199

0 commit comments

Comments
 (0)