Skip to content

Commit ac7789c

Browse files
committed
add core-ci-pr task which does a full build without mangling
1 parent 3ccf16e commit ac7789c

File tree

3 files changed

+24
-6
lines changed

3 files changed

+24
-6
lines changed

build/gulpfile.compile.js

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,22 @@ const task = require('./lib/task');
1111
const compilation = require('./lib/compilation');
1212
const optimize = require('./lib/optimize');
1313

14-
// Full compile, including nls and inline sources in sourcemaps, for build
15-
const compileBuildTask = task.define('compile-build',
16-
task.series(
14+
function makeCompileBuildTask(disableMangle) {
15+
return task.series(
1716
util.rimraf('out-build'),
1817
util.buildWebNodePaths('out-build'),
1918
compilation.compileApiProposalNamesTask,
20-
compilation.compileTask('src', 'out-build', true),
19+
compilation.compileTask('src', 'out-build', true, { disableMangle }),
2120
optimize.optimizeLoaderTask('out-build', 'out-build', true)
22-
)
23-
);
21+
);
22+
}
23+
24+
// Full compile, including nls and inline sources in sourcemaps, mangling, minification, for build
25+
const compileBuildTask = task.define('compile-build', makeCompileBuildTask(false));
2426
gulp.task(compileBuildTask);
2527
exports.compileBuildTask = compileBuildTask;
28+
29+
// Full compile for PR ci, e.g no mangling
30+
const compileBuildTaskPullRequest = task.define('compile-build-pr', makeCompileBuildTask(true));
31+
gulp.task(compileBuildTaskPullRequest);
32+
exports.compileBuildTaskPullRequest = compileBuildTaskPullRequest;

build/gulpfile.vscode.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,16 @@ const core = task.define('core-ci', task.series(
150150
));
151151
gulp.task(core);
152152

153+
const corePr = task.define('core-ci-pr', task.series(
154+
gulp.task('compile-build-pr'),
155+
task.parallel(
156+
gulp.task('minify-vscode'),
157+
gulp.task('minify-vscode-reh'),
158+
gulp.task('minify-vscode-reh-web'),
159+
)
160+
));
161+
gulp.task(corePr);
162+
153163
/**
154164
* Compute checksums for some files.
155165
*

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@
5757
"minify-vscode-reh-web": "node --max_old_space_size=4095 ./node_modules/gulp/bin/gulp.js minify-vscode-reh-web",
5858
"hygiene": "node --max_old_space_size=4095 ./node_modules/gulp/bin/gulp.js hygiene",
5959
"core-ci": "node --max_old_space_size=8095 ./node_modules/gulp/bin/gulp.js core-ci",
60+
"core-ci-pr": "node --max_old_space_size=4095 ./node_modules/gulp/bin/gulp.js core-ci-pr",
6061
"extensions-ci": "node --max_old_space_size=4095 ./node_modules/gulp/bin/gulp.js extensions-ci",
6162
"perf": "node scripts/code-perf.js"
6263
},

0 commit comments

Comments
 (0)