cleaning the code

Author: aiday-mar

src/vs/workbench/contrib/interactiveEditor/browser/interactiveEditorActions.ts

@@ -14,7 +14,7 @@ import { CTX_INTERACTIVE_EDITOR_FOCUSED, CTX_INTERACTIVE_EDITOR_HAS_ACTIVE_REQUE
 import { localize } from 'vs/nls';
 import { IAction2Options, MenuRegistry } from 'vs/platform/actions/common/actions';
 import { IClipboardService } from 'vs/platform/clipboard/common/clipboardService';
-import { ContextKeyExpr, IContextKeyService } from 'vs/platform/contextkey/common/contextkey';
+import { ContextKeyExpr } from 'vs/platform/contextkey/common/contextkey';
 import { ServicesAccessor } from 'vs/platform/instantiation/common/instantiation';
 import { KeybindingWeight } from 'vs/platform/keybinding/common/keybindingsRegistry';
 import { IQuickInputService, IQuickPickItem } from 'vs/platform/quickinput/common/quickInput';
@@ -565,8 +565,6 @@ export class ExpandMessageAction extends AbstractInteractiveEditorAction {
 		});
 	}
 	override runInteractiveEditorCommand(_accessor: ServicesAccessor, ctrl: InteractiveEditorController, _editor: ICodeEditor, ..._args: any[]): void {
-		console.log('running the expand message action');
-		console.log('CTX_INTERACTIVE_EDITOR_MESSAGE_CROP_STATE : ', CTX_INTERACTIVE_EDITOR_MESSAGE_CROP_STATE.getValue(_accessor.get(IContextKeyService)));
 		ctrl.updateExpansionState(true);
 	}
 }
@@ -587,8 +585,6 @@ export class ContractMessageAction extends AbstractInteractiveEditorAction {
 		});
 	}
 	override runInteractiveEditorCommand(_accessor: ServicesAccessor, ctrl: InteractiveEditorController, _editor: ICodeEditor, ..._args: any[]): void {
-		console.log('running the contract message action');
-		console.log('CTX_INTERACTIVE_EDITOR_MESSAGE_CROP_STATE : ', CTX_INTERACTIVE_EDITOR_MESSAGE_CROP_STATE.getValue(_accessor.get(IContextKeyService)));
 		ctrl.updateExpansionState(false);
 	}
 }

src/vs/workbench/contrib/interactiveEditor/browser/interactiveEditorController.ts

@@ -556,12 +556,10 @@ export class InteractiveEditorController implements IEditorContribution {
 			this._zone.widget.updateStatus('');
 			this._zone.widget.updateMarkdownMessage(renderedMarkdown.element);
 			this._zone.widget.updateToolbar(true);
-			console.log('inside of SHOW_RESPONSE');
-			console.log('this._activeSession.lastExpansionState', this._activeSession.lastExpansionState);
-			const state = this._activeSession.newlySelected ? (this._activeSession.lastExpansionState ?? this._zone.widget.cropState()) : this._zone.widget.cropState();
+			const expansionState = this._activeSession.newlySelected ? (this._activeSession.lastExpansionState ?? this._zone.widget.expansionState()) : this._zone.widget.expansionState();
 			this._activeSession.newlySelected = false;
-			this._activeSession.lastExpansionState = state;
-			this._zone.widget.updateMarkdownMessageExpansionState(state);
+			this._activeSession.lastExpansionState = expansionState;
+			this._zone.widget.updateMarkdownMessageExpansionState(expansionState);
 
 		} else if (response instanceof EditResponse) {
 			// edit response -> complex...
@@ -670,12 +668,10 @@ export class InteractiveEditorController implements IEditorContribution {
 	}
 
 	updateExpansionState(expand: boolean) {
-		console.log('inside of update expansion state, expand : ', expand);
 		if (this._activeSession) {
-			const state = expand ? ExpansionState.EXPANDED : ExpansionState.CROPPED;
-			console.log('state : ', state);
-			this._zone.widget.updateMarkdownMessageExpansionState(state);
-			this._activeSession.lastExpansionState = state;
+			const expansionState = expand ? ExpansionState.EXPANDED : ExpansionState.CROPPED;
+			this._zone.widget.updateMarkdownMessageExpansionState(expansionState);
+			this._activeSession.lastExpansionState = expansionState;
 		}
 	}
 

src/vs/workbench/contrib/interactiveEditor/browser/interactiveEditorWidget.ts

@@ -176,6 +176,7 @@ export class InteractiveEditorWidget {
 
 	private _lastDim: Dimension | undefined;
 	private _isLayouting: boolean = false;
+	private _expansionState: ExpansionState = ExpansionState.NOT_CROPPED;
 
 	constructor(
 		parentEditor: ICodeEditor,
@@ -357,8 +358,6 @@ export class InteractiveEditorWidget {
 		this._store.dispose();
 		this._ctxInputEmpty.reset();
 		this._ctxMessageCropState.reset();
-		console.log('inside of dispose');
-		console.log('this._ctxMessageCropState.get() : ', this._ctxMessageCropState.get());
 	}
 
 	get domNode(): HTMLElement {
@@ -431,34 +430,22 @@ export class InteractiveEditorWidget {
 		this._onDidChangeHeight.fire();
 	}
 
-	cropState() {
-		if (this._elements.message.scrollHeight > this._elements.message.clientHeight) {
-			return ExpansionState.CROPPED;
-		} else {
-			return ExpansionState.NOT_CROPPED;
-		}
+	expansionState() {
+		return this._expansionState;
 	}
 
 	updateMarkdownMessage(message: Node | undefined) {
-		console.log('inside of update markdown message');
 		this._elements.markdownMessage.classList.toggle('hidden', !message);
 		if (!message) {
-			this._ctxMessageCropState.reset();
-			console.log('inside of case when message is undefined');
-			console.log('this._ctxMessageCropState.get() : ', this._ctxMessageCropState.get());
 			reset(this._elements.message);
+			this._ctxMessageCropState.reset();
+			this._expansionState = ExpansionState.NOT_CROPPED;
 		} else {
-			// reset the css to what it was before
 			this._elements.message.style.webkitLineClamp = '3';
 			reset(this._elements.message, message);
-			console.log('message overflowing : ', this._elements.message.scrollHeight > this._elements.message.clientHeight);
-			if (this._elements.message.scrollHeight > this._elements.message.clientHeight) {
-				this._ctxMessageCropState.set(ExpansionState.CROPPED);
-			} else {
-				this._ctxMessageCropState.set(ExpansionState.NOT_CROPPED);
-			}
-			console.log('inside of the case when the message is defined');
-			console.log('this._ctxMessageCropState.get() : ', this._ctxMessageCropState.get());
+			const expansionState = this._elements.message.scrollHeight > this._elements.message.clientHeight ? ExpansionState.CROPPED : ExpansionState.NOT_CROPPED;
+			this._ctxMessageCropState.set(expansionState);
+			this._expansionState = expansionState;
 		}
 		this._onDidChangeHeight.fire();
 	}
@@ -508,12 +495,9 @@ export class InteractiveEditorWidget {
 	}
 
 	updateMarkdownMessageExpansionState(expansionState: ExpansionState) {
-		console.log('inside of update markdown message expansion state');
-		console.log('expansionState : ', expansionState);
 		this._ctxMessageCropState.set(expansionState);
-		console.log('this._ctxMessageCropState.get() : ', this._ctxMessageCropState.get());
+		this._expansionState = expansionState;
 		this._elements.message.style.webkitLineClamp = expansionState === ExpansionState.NOT_CROPPED ? 'none' : (expansionState === ExpansionState.EXPANDED ? '10' : '3');
-		console.log('this._elements.message.style.webkitLineClamp : ', this._elements.message.style.webkitLineClamp);
 		this._onDidChangeHeight.fire();
 	}