Skip to content

Commit adfa191

Browse files
authored
adds limit on issue reporter description (microsoft#208346)
1 parent 774f610 commit adfa191

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

src/vs/code/electron-sandbox/issue/issueReporterPage.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ export default (): string => `
8383
<textarea name="description" id="description" placeholder="${escape(localize('details', "Please enter details."))}" required></textarea>
8484
</div>
8585
<div id="description-empty-error" class="validation-error hidden" role="alert">${escape(localize('descriptionEmptyValidation', "A description is required."))}</div>
86+
<div id="description-short-error" class="validation-error hidden" role="alert">${escape(localize('descriptionTooShortValidation', "Please provide a longer description."))}</div>
8687
</div>
8788
8889
<div class="system-info" id="block-container">

src/vs/code/electron-sandbox/issue/issueReporterService.ts

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -924,13 +924,24 @@ export class IssueReporter extends Disposable {
924924
private validateInput(inputId: string): boolean {
925925
const inputElement = (<HTMLInputElement>this.getElementById(inputId));
926926
const inputValidationMessage = this.getElementById(`${inputId}-empty-error`);
927+
const descriptionShortMessage = this.getElementById(`description-short-error`);
927928
if (!inputElement.value) {
928929
inputElement.classList.add('invalid-input');
929930
inputValidationMessage?.classList.remove('hidden');
931+
descriptionShortMessage?.classList.add('hidden');
930932
return false;
931-
} else {
933+
} else if (inputId === 'description' && inputElement.value.length < 10) {
934+
inputElement.classList.add('invalid-input');
935+
descriptionShortMessage?.classList.remove('hidden');
936+
inputValidationMessage?.classList.add('hidden');
937+
return false;
938+
}
939+
else {
932940
inputElement.classList.remove('invalid-input');
933941
inputValidationMessage?.classList.add('hidden');
942+
if (inputId === 'description') {
943+
descriptionShortMessage?.classList.add('hidden');
944+
}
934945
return true;
935946
}
936947
}

0 commit comments

Comments
 (0)