fix syncing profiles (microsoft#209336)

fix microsoft#208710

Author: sandy081

src/vs/platform/userDataSync/common/userDataProfilesManifestSync.ts

@@ -187,6 +187,11 @@ export class UserDataProfilesManifestSynchroniser extends AbstractSynchroniser i
 
 		if (localChange !== Change.None) {
 			await this.backupLocal(stringifyLocalProfiles(this.getLocalUserDataProfiles(), false));
+			await Promise.all(local.removed.map(async profile => {
+				this.logService.trace(`${this.syncResourceLogLabel}: Removing '${profile.name}' profile...`);
+				await this.userDataProfilesService.removeProfile(profile);
+				this.logService.info(`${this.syncResourceLogLabel}: Removed profile '${profile.name}'.`);
+			}));
 			const promises: Promise<any>[] = [];
 			for (const profile of local.added) {
 				promises.push((async () => {
@@ -195,13 +200,6 @@ export class UserDataProfilesManifestSynchroniser extends AbstractSynchroniser i
 					this.logService.info(`${this.syncResourceLogLabel}: Created profile '${profile.name}'.`);
 				})());
 			}
-			for (const profile of local.removed) {
-				promises.push((async () => {
-					this.logService.trace(`${this.syncResourceLogLabel}: Removing '${profile.name}' profile...`);
-					await this.userDataProfilesService.removeProfile(profile);
-					this.logService.info(`${this.syncResourceLogLabel}: Removed profile '${profile.name}'.`);
-				})());
-			}
 			for (const profile of local.updated) {
 				const localProfile = this.userDataProfilesService.profiles.find(p => p.id === profile.id);
 				if (localProfile) {