Merge pull request microsoft#180738 from microsoft/aamunger/scrollingWhileStreaming

amunger · web-flow · commit af8b51ed1eea · 2023-04-24T12:45:51.000-07:00
don't stick the scrollbar to the bottom if scrolled up
diff --git a/extensions/notebook-renderers/src/index.ts b/extensions/notebook-renderers/src/index.ts
@@ -209,7 +209,8 @@ function initializeScroll(scrollableElement: HTMLElement, disposables: Disposabl
 }
 
 // Find the scrollTop of the existing scrollable output, return undefined if at the bottom or element doesn't exist
-function findScrolledHeight(scrollableElement: HTMLElement): number | undefined {
+function findScrolledHeight(container: HTMLElement): number | undefined {
+	const scrollableElement = container.querySelector(scrollableClass);
 	if (scrollableElement && scrollableElement.scrollHeight - scrollableElement.scrollTop - scrollableElement.clientHeight > 2) {
 		// not scrolled to the bottom
 		return scrollableElement.scrollTop;

Original file line number	Diff line number	Diff line change
`@@ -209,7 +209,8 @@ function initializeScroll(scrollableElement: HTMLElement, disposables: Disposabl`
`209`	`209`	`}`
`210`	`210`
`211`	`211`	`// Find the scrollTop of the existing scrollable output, return undefined if at the bottom or element doesn't exist`
`212`		`-function findScrolledHeight(scrollableElement: HTMLElement): number \| undefined {`
	`212`	`+function findScrolledHeight(container: HTMLElement): number \| undefined {`
	`213`	`+ const scrollableElement = container.querySelector(scrollableClass);`
`213`	`214`	`if (scrollableElement && scrollableElement.scrollHeight - scrollableElement.scrollTop - scrollableElement.clientHeight > 2) {`
`214`	`215`	`// not scrolled to the bottom`
`215`	`216`	`return scrollableElement.scrollTop;`