Skip to content

Commit af93ce2

Browse files
authored
Merge pull request microsoft#185361 from microsoft/merogge/cue-touch-up
follow up cue work
2 parents 2dad7f5 + f929eaa commit af93ce2

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

src/vs/platform/audioCues/browser/audioCueService.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,10 @@ export class AudioCueService extends Disposable implements IAudioCueService {
5353
await Promise.all(Array.from(sounds).map(sound => this.playSound(sound, true)));
5454
}
5555

56+
/**
57+
* Gaming and other apps often play a sound variant when the same event happens again
58+
* for an improved experience. This function plays a random sound from the given group to accomplish that.
59+
*/
5660
public playRandomAudioCue(groupId: AudioCueGroupId, allowManyInParallel?: boolean): void {
5761
const cues = AudioCue.allAudioCues.filter(cue => cue.groupId === groupId);
5862
const index = Math.floor(Math.random() * cues.length);
@@ -350,7 +354,7 @@ export class AudioCue {
350354
settingsKey: 'audioCues.chatRequestSent'
351355
});
352356

353-
public static readonly chatResponseReceived = {
357+
private static readonly chatResponseReceived = {
354358
name: localize('audioCues.chatResponseReceived', 'Chat Response Received'),
355359
settingsKey: 'audioCues.chatResponseReceived',
356360
groupId: AudioCueGroupId.chatResponseReceived

0 commit comments

Comments
 (0)