Marker service handling of unsupported schemas (microsoft#158176)

Author: lszomoru

src/vs/platform/markers/common/markerService.ts

@@ -12,6 +12,8 @@ import { Schemas } from 'vs/base/common/network';
 import { URI } from 'vs/base/common/uri';
 import { IMarker, IMarkerData, IMarkerService, IResourceMarker, MarkerSeverity, MarkerStatistics } from './markers';
 
+export const unsupportedSchemas = new Set([Schemas.inMemory, Schemas.vscodeSourceControl, Schemas.walkThrough, Schemas.walkThroughSnippet]);
+
 class DoubleResourceMap<V>{
 
 	private _byResource = new ResourceMap<Map<string, V>>();
@@ -103,7 +105,7 @@ class MarkerStats implements MarkerStatistics {
 		const result: MarkerStatistics = { errors: 0, warnings: 0, infos: 0, unknowns: 0 };
 
 		// TODO this is a hack
-		if (resource.scheme === Schemas.inMemory || resource.scheme === Schemas.walkThrough || resource.scheme === Schemas.walkThroughSnippet || resource.scheme === Schemas.vscodeSourceControl) {
+		if (unsupportedSchemas.has(resource.scheme)) {
 			return result;
 		}
 
@@ -198,6 +200,10 @@ export class MarkerService implements IMarkerService {
 			tags,
 		} = data;
 
+		if (unsupportedSchemas.has(resource.scheme)) {
+			return undefined;
+		}
+
 		if (!message) {
 			return undefined;
 		}

src/vs/workbench/contrib/markers/browser/markersTable.ts

@@ -5,7 +5,6 @@
 
 import { localize } from 'vs/nls';
 import * as DOM from 'vs/base/browser/dom';
-import * as network from 'vs/base/common/network';
 import { Event } from 'vs/base/common/event';
 import { ITableContextMenuEvent, ITableEvent, ITableRenderer, ITableVirtualDelegate } from 'vs/base/browser/ui/table/table';
 import { Disposable } from 'vs/base/common/lifecycle';
@@ -29,6 +28,7 @@ import { isUndefinedOrNull } from 'vs/base/common/types';
 import { IProblemsWidget } from 'vs/workbench/contrib/markers/browser/markersView';
 import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey';
 import { Range } from 'vs/editor/common/core/range';
+import { unsupportedSchemas } from 'vs/platform/markers/common/markerService';
 
 const $ = DOM.$;
 
@@ -411,7 +411,7 @@ export class MarkersTable extends Disposable implements IProblemsWidget {
 		const items: MarkerTableItem[] = [];
 		for (const resourceMarker of this.resourceMarkers) {
 			for (const marker of resourceMarker.markers) {
-				if (marker.resource.scheme === network.Schemas.walkThrough || marker.resource.scheme === network.Schemas.walkThroughSnippet || marker.resource.scheme === network.Schemas.vscodeSourceControl) {
+				if (unsupportedSchemas.has(marker.resource.scheme)) {
 					continue;
 				}
 

src/vs/workbench/contrib/markers/browser/markersTreeViewer.ts

@@ -50,6 +50,7 @@ import { Link } from 'vs/platform/opener/browser/link';
 import { ILanguageFeaturesService } from 'vs/editor/common/services/languageFeatures';
 import { IContextKey, IContextKeyService } from 'vs/platform/contextkey/common/contextkey';
 import { MarkersContextKeys, MarkersViewMode } from 'vs/workbench/contrib/markers/common/markers';
+import { unsupportedSchemas } from 'vs/platform/markers/common/markerService';
 
 interface IResourceMarkersTemplateData {
 	resourceLabel: IResourceLabel;
@@ -456,7 +457,7 @@ export class Filter implements ITreeFilter<MarkerElement, FilterData> {
 	}
 
 	private filterResourceMarkers(resourceMarkers: ResourceMarkers): TreeFilterResult<FilterData> {
-		if (resourceMarkers.resource.scheme === network.Schemas.walkThrough || resourceMarkers.resource.scheme === network.Schemas.walkThroughSnippet || resourceMarkers.resource.scheme === network.Schemas.vscodeSourceControl) {
+		if (unsupportedSchemas.has(resourceMarkers.resource.scheme)) {
 			return false;
 		}