Skip to content

Commit b16578f

Browse files
authored
Make sure we always reset the code action widget context when the widget is hidden (microsoft#162278)
Make sure we always reset the `ctxMenuWidgetVisible` widget context when the widget is hidden We've seen a handful of reports of keybindings not working. I'm not able to repo this, but the root cause may be that code action's context keys are not being cleared properly This fixes it to make sure we always reset the context when the widget is closed
1 parent 0c22a33 commit b16578f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/vs/editor/contrib/codeAction/browser/codeActionWidget.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -419,7 +419,6 @@ export class CodeActionWidget extends Disposable {
419419
}
420420

421421
public hide() {
422-
this._ctxMenuWidgetVisible.reset();
423422
this.codeActionList.clear();
424423
this._contextViewService.hideContextView();
425424
}
@@ -530,6 +529,7 @@ export class CodeActionWidget extends Disposable {
530529
});
531530

532531
this.currentShowingContext = undefined;
532+
this._ctxMenuWidgetVisible.reset();
533533
delegate.onHide(cancelled);
534534
}
535535

0 commit comments

Comments
 (0)