Skip to content

Commit b341631

Browse files
committed
rename suggestions: dispose listeners & clear focused-elements list on blur
1 parent 372baec commit b341631

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

src/vs/editor/contrib/rename/browser/renameInputField.ts

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -414,8 +414,12 @@ class CandidatesView {
414414
private _lineHeight: number;
415415
private _availableHeight: number;
416416

417+
private _disposables: DisposableStore;
418+
417419
constructor(parent: HTMLElement, opts: { fontInfo: FontInfo; onSelectionChange: () => void }) {
418420

421+
this._disposables = new DisposableStore();
422+
419423
this._availableHeight = 0;
420424

421425
this._lineHeight = opts.fontInfo.lineHeight;
@@ -466,11 +470,15 @@ class CandidatesView {
466470
}
467471
);
468472

469-
this._listWidget.onDidChangeSelection(e => {
473+
this._disposables.add(this._listWidget.onDidChangeSelection(e => {
470474
if (e.elements.length > 0) {
471475
opts.onSelectionChange();
472476
}
473-
});
477+
}));
478+
479+
this._disposables.add(this._listWidget.onDidBlur(e => {
480+
this._listWidget.setFocus([]);
481+
}));
474482

475483
this._listWidget.style(defaultListStyles);
476484
}
@@ -565,6 +573,7 @@ class CandidatesView {
565573

566574
dispose() {
567575
this._listWidget.dispose();
576+
this._disposables.dispose();
568577
}
569578
}
570579

0 commit comments

Comments
 (0)