Re microsoft#164715. Better error handling of notebook opening (microsoft#164737)

rebornix · web-flow · commit b39fd56213e0 · 2022-10-26T20:30:49.000+02:00
diff --git a/src/vs/workbench/contrib/notebook/browser/notebookEditor.ts b/src/vs/workbench/contrib/notebook/browser/notebookEditor.ts
@@ -290,7 +290,8 @@ export class NotebookEditor extends EditorPane implements IEditorPaneWithSelecti
 				}
 			}
 		} catch (e) {
-			const error = createErrorWithActions(e instanceof Error ? e : new Error(e.message), [
+			console.warn(e);
+			const error = createErrorWithActions(e instanceof Error ? e : new Error((e ? e.message : '')), [
 				toAction({
 					id: 'workbench.notebook.action.openInTextEditor', label: localize('notebookOpenInTextEditor', "Open in Text Editor"), run: async () => {
 						const activeEditorPane = this._editorService.activeEditorPane;

Original file line number	Diff line number	Diff line change
`@@ -290,7 +290,8 @@ export class NotebookEditor extends EditorPane implements IEditorPaneWithSelecti`
`290`	`290`	`}`
`291`	`291`	`}`
`292`	`292`	`} catch (e) {`
`293`		`- const error = createErrorWithActions(e instanceof Error ? e : new Error(e.message), [`
	`293`	`+ console.warn(e);`
	`294`	`+ const error = createErrorWithActions(e instanceof Error ? e : new Error((e ? e.message : '')), [`
`294`	`295`	`toAction({`
`295`	`296`	`id: 'workbench.notebook.action.openInTextEditor', label: localize('notebookOpenInTextEditor', "Open in Text Editor"), run: async () => {`
`296`	`297`	`const activeEditorPane = this._editorService.activeEditorPane;`