Skip to content

Commit b4952d1

Browse files
authored
fix: remove emulation check and notification on windows (microsoft#186008)
1 parent 352e7da commit b4952d1

File tree

3 files changed

+4
-11
lines changed

3 files changed

+4
-11
lines changed

src/vs/code/electron-main/app.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1279,7 +1279,7 @@ export class CodeApplication extends Disposable {
12791279
// Crash reporter
12801280
this.updateCrashReporterEnablement();
12811281

1282-
if (app.runningUnderARM64Translation) {
1282+
if (isMacintosh && app.runningUnderARM64Translation) {
12831283
this.windowsMainService?.sendToFocused('vscode:showTranslatedBuildWarning');
12841284
}
12851285

src/vs/platform/native/electron-main/nativeHostMainService.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -490,7 +490,7 @@ export class NativeHostMainService extends Disposable implements INativeHostMain
490490
}
491491

492492
async isRunningUnderARM64Translation(): Promise<boolean> {
493-
if (isLinux) {
493+
if (isLinux || isWindows) {
494494
return false;
495495
}
496496
return app.runningUnderARM64Translation;

src/vs/workbench/electron-sandbox/window.ts

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -236,15 +236,8 @@ export class NativeWindow extends Disposable {
236236
label: localize('downloadArmBuild', "Download"),
237237
run: () => {
238238
const quality = this.productService.quality;
239-
let stableURL = '';
240-
let insidersURL = '';
241-
if (isMacintosh) {
242-
stableURL = 'https://code.visualstudio.com/docs/?dv=osx';
243-
insidersURL = 'https://code.visualstudio.com/docs/?dv=osx&build=insiders';
244-
} else if (isWindows) {
245-
stableURL = 'https://code.visualstudio.com/docs/?dv=win32arm64user';
246-
insidersURL = 'https://code.visualstudio.com/docs/?dv=win32arm64user&build=insiders';
247-
}
239+
const stableURL = 'https://code.visualstudio.com/docs/?dv=osx';
240+
const insidersURL = 'https://code.visualstudio.com/docs/?dv=osx&build=insiders';
248241
this.openerService.open(quality === 'stable' ? stableURL : insidersURL);
249242
}
250243
}]

0 commit comments

Comments
 (0)