Skip to content

Commit b4a26e9

Browse files
committed
Do not block if unable to verify
1 parent 2238a14 commit b4a26e9

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

src/vs/platform/extensionManagement/node/extensionDownloader.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,11 +68,14 @@ export class ExtensionsDownloader extends Disposable {
6868
}
6969
this.logService.info(`Extension signature verification: ${extension.identifier.id}. Verification status: ${verificationStatus}.`);
7070
} catch (error) {
71-
const code: string = (error as ExtensionSignatureVerificationError).code;
71+
const sigError = error as ExtensionSignatureVerificationError;
72+
const code: string = sigError.code;
7273

7374
if (code === 'UnknownError') {
7475
verificationStatus = ExtensionVerificationStatus.UnknownError;
7576
this.logService.warn(`Extension signature verification: ${extension.identifier.id}. Verification status: ${verificationStatus}.`);
77+
} else if (!sigError.didExecute) {
78+
this.logService.warn(`Extension signature verification: ${extension.identifier.id}. Verification status: ${verificationStatus} (${code})`);
7679
} else {
7780
await this.delete(signatureArchiveLocation);
7881
await this.delete(location);

src/vs/platform/extensionManagement/node/extensionSignatureVerificationService.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ declare module vsceSign {
3434
*/
3535
export interface ExtensionSignatureVerificationError extends Error {
3636
readonly code: string;
37+
readonly didExecute: boolean;
3738
}
3839

3940
export class ExtensionSignatureVerificationService implements IExtensionSignatureVerificationService {

0 commit comments

Comments
 (0)