Skip to content

Commit b50cc59

Browse files
authored
Make tree view always write text/uri-list (microsoft#153758)
Fixes microsoft#152836 This forces the treeview to always write `text/uri-list` when it can. Previouly we only wrote it when there was not already a `text/uri-list` on the data transfer I have no clue where the original `text/uri-list` is coming from and it only seems to get set on windows
1 parent 39a346c commit b50cc59

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/vs/editor/browser/dnd.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ const INTERNAL_DND_MIME_TYPES = Object.freeze([
4141
DataTransfers.RESOURCES,
4242
]);
4343

44-
export function addExternalEditorsDropData(dataTransfer: VSDataTransfer, dragEvent: DragEvent) {
45-
if (dragEvent.dataTransfer && !dataTransfer.has(Mimes.uriList)) {
44+
export function addExternalEditorsDropData(dataTransfer: VSDataTransfer, dragEvent: DragEvent, overwriteUriList = false) {
45+
if (dragEvent.dataTransfer && (overwriteUriList || !dataTransfer.has(Mimes.uriList))) {
4646
const editorData = extractEditorsDropData(dragEvent)
4747
.filter(input => input.resource)
4848
.map(input => input.resource!.toString());

src/vs/workbench/browser/parts/views/treeView.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1495,7 +1495,7 @@ export class CustomTreeViewDragAndDrop implements ITreeDragAndDrop<ITreeItem> {
14951495
}
14961496

14971497
const originalDataTransfer = toVSDataTransfer(originalEvent.dataTransfer);
1498-
addExternalEditorsDropData(originalDataTransfer, originalEvent);
1498+
addExternalEditorsDropData(originalDataTransfer, originalEvent, true);
14991499

15001500
const outDataTransfer = new VSDataTransfer();
15011501
for (const [type, item] of originalDataTransfer.entries()) {

0 commit comments

Comments
 (0)