only allow resolveCompletionItem to change documentation, detail, and additionalTextEdits (microsoft#183224)

jrieken · web-flow · commit b7e813f22f15 · 2023-05-23T08:44:50.000-07:00
microsoft#183092 (comment)
diff --git a/src/vs/workbench/api/common/extHostLanguageFeatures.ts b/src/vs/workbench/api/common/extHostLanguageFeatures.ts
@@ -1033,7 +1033,12 @@ class CompletionsAdapter {
 			return undefined;
 		}
 
-		return this._convertCompletionItem(resolvedItem, id);
+		return this._convertCompletionItem({
+			...item,
+			documentation: resolvedItem.documentation,
+			detail: resolvedItem.detail,
+			additionalTextEdits: resolvedItem.additionalTextEdits
+		}, id);
 	}
 
 	releaseCompletionItems(id: number): any {

Original file line number	Diff line number	Diff line change
`@@ -1033,7 +1033,12 @@ class CompletionsAdapter {`
`1033`	`1033`	`return undefined;`
`1034`	`1034`	`}`
`1035`	`1035`
`1036`		`- return this._convertCompletionItem(resolvedItem, id);`
	`1036`	`+ return this._convertCompletionItem({`
	`1037`	`+ ...item,`
	`1038`	`+ documentation: resolvedItem.documentation,`
	`1039`	`+ detail: resolvedItem.detail,`
	`1040`	`+ additionalTextEdits: resolvedItem.additionalTextEdits`
	`1041`	`+ }, id);`
`1037`	`1042`	`}`
`1038`	`1043`
`1039`	`1044`	`releaseCompletionItems(id: number): any {`