Check for treatment and guard against malformed JSON in featured extension experiment (microsoft#178180)

Check for treatment and guard against malformed JSON

Author: bhavyaus

src/vs/workbench/contrib/welcomeGettingStarted/browser/featuredExtensionService.ts

@@ -59,7 +59,7 @@ export class FeaturedExtensionsService extends Disposable implements IFeaturedEx
 
 		await this._init();
 
-		let treatments = this.treatment?.extensions.filter(extension => !this.ignoredExtensions.has(extension)) ?? new Array<string>();
+		let treatments = this.treatment?.extensions?.filter(extension => !this.ignoredExtensions.has(extension)) ?? new Array<string>();
 		const featuredExtensions: IFeaturedExtension[] = new Array();
 
 		if (this.treatment?.showAsList !== 'true' && treatments.length > 0) {
@@ -94,12 +94,16 @@ export class FeaturedExtensionsService extends Disposable implements IFeaturedEx
 			new Promise<string | undefined>(resolve => setTimeout(() => resolve(''), 2000))
 		]);
 
-		this.treatment = extensions ? JSON.parse(extensions) : { extensions: [] };
+		try {
+			this.treatment = extensions ? JSON.parse(extensions) : { extensions: [] };
+		} catch {
+		}
+
 		this.title = extensionListTitle ?? localize('gettingStarted.featuredTitle', 'Featured');
 
-		if (this.treatment) {
+		if (this.treatment?.extensions && Array.isArray(this.treatment.extensions)) {
 			const installed = await this.extensionManagementService.getInstalled();
-			for (const extension of Object.values(this.treatment.extensions)) {
+			for (const extension of this.treatment.extensions) {
 				if (installed.some(e => ExtensionIdentifier.equals(e.identifier.id, extension))) {
 					this.ignoredExtensions.add(extension);
 				}