Skip to content

Commit b97827d

Browse files
authored
Adopt notebook serializer for notebook document tests (microsoft#165081)
For microsoft#160580 Also remove one test that is no longer relevant
1 parent 9b3e147 commit b97827d

File tree

1 file changed

+4
-22
lines changed

1 file changed

+4
-22
lines changed

extensions/vscode-api-tests/src/singlefolder-tests/notebook.document.test.ts

Lines changed: 4 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,6 @@ suite('Notebook Document', function () {
2020
}
2121
};
2222

23-
const complexContentProvider = new class implements vscode.NotebookContentProvider {
24-
async openNotebook(uri: vscode.Uri, _openContext: vscode.NotebookDocumentOpenContext): Promise<vscode.NotebookData> {
25-
return new vscode.NotebookData(
26-
[new vscode.NotebookCellData(vscode.NotebookCellKind.Code, uri.toString(), 'javascript')],
27-
);
28-
}
29-
};
30-
3123
const disposables: vscode.Disposable[] = [];
3224
const testDisposables: vscode.Disposable[] = [];
3325

@@ -45,17 +37,7 @@ suite('Notebook Document', function () {
4537
});
4638

4739
suiteSetup(function () {
48-
disposables.push(vscode.workspace.registerNotebookContentProvider('notebook.nbdtest', complexContentProvider));
49-
disposables.push(vscode.workspace.registerNotebookSerializer('notebook.nbdserializer', simpleContentProvider));
50-
});
51-
52-
test('cannot register sample provider multiple times', function () {
53-
assert.throws(() => {
54-
vscode.workspace.registerNotebookContentProvider('notebook.nbdtest', complexContentProvider);
55-
});
56-
// assert.throws(() => {
57-
// vscode.workspace.registerNotebookSerializer('notebook.nbdserializer', simpleContentProvider);
58-
// });
40+
disposables.push(vscode.workspace.registerNotebookSerializer('notebook.nbdtest', simpleContentProvider));
5941
});
6042

6143
test('cannot open unknown types', async function () {
@@ -131,7 +113,7 @@ suite('Notebook Document', function () {
131113
});
132114

133115
test('open untitled notebook', async function () {
134-
const nb = await vscode.workspace.openNotebookDocument('notebook.nbdserializer');
116+
const nb = await vscode.workspace.openNotebookDocument('notebook.nbdtest');
135117
assert.strictEqual(nb.isUntitled, true);
136118
assert.strictEqual(nb.isClosed, false);
137119
assert.strictEqual(nb.uri.scheme, 'untitled');
@@ -140,7 +122,7 @@ suite('Notebook Document', function () {
140122

141123
test('open untitled with data', async function () {
142124
const nb = await vscode.workspace.openNotebookDocument(
143-
'notebook.nbdserializer',
125+
'notebook.nbdtest',
144126
new vscode.NotebookData([
145127
new vscode.NotebookCellData(vscode.NotebookCellKind.Code, 'console.log()', 'javascript'),
146128
new vscode.NotebookCellData(vscode.NotebookCellKind.Markup, 'Hey', 'markdown'),
@@ -353,7 +335,7 @@ suite('Notebook Document', function () {
353335
});
354336

355337
test('dirty state - serializer', async function () {
356-
const resource = await utils.createRandomFile(undefined, undefined, '.nbdserializer');
338+
const resource = await utils.createRandomFile(undefined, undefined, '.nbdtest');
357339
const document = await vscode.workspace.openNotebookDocument(resource);
358340
assert.strictEqual(document.isDirty, false);
359341

0 commit comments

Comments
 (0)