Skip to content

Commit b982536

Browse files
author
najmiehsa
authored
Use CSS variables over registerThemingParticipant - rulers viewparts (microsoft#165466)
* edits * edits
1 parent 1e10847 commit b982536

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

src/vs/editor/browser/viewParts/rulers/rulers.css

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,5 @@
66
.monaco-editor .view-ruler {
77
position: absolute;
88
top: 0;
9-
}
9+
box-shadow: 1px 0 0 0 var(--vscode-editorRuler-ruler) inset;
10+
}

src/vs/editor/browser/viewParts/rulers/rulers.ts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,9 @@
66
import 'vs/css!./rulers';
77
import { FastDomNode, createFastDomNode } from 'vs/base/browser/fastDomNode';
88
import { ViewPart } from 'vs/editor/browser/view/viewPart';
9-
import { editorRuler } from 'vs/editor/common/core/editorColorRegistry';
109
import { RenderingContext, RestrictedRenderingContext } from 'vs/editor/browser/view/renderingContext';
1110
import { ViewContext } from 'vs/editor/common/viewModel/viewContext';
1211
import * as viewEvents from 'vs/editor/common/viewEvents';
13-
import { registerThemingParticipant } from 'vs/platform/theme/common/themeService';
1412
import { EditorOption, IRulerOption } from 'vs/editor/common/config/editorOptions';
1513

1614
export class Rulers extends ViewPart {
@@ -100,10 +98,3 @@ export class Rulers extends ViewPart {
10098
}
10199
}
102100
}
103-
104-
registerThemingParticipant((theme, collector) => {
105-
const rulerColor = theme.getColor(editorRuler);
106-
if (rulerColor) {
107-
collector.addRule(`.monaco-editor .view-ruler { box-shadow: 1px 0 0 0 ${rulerColor} inset; }`);
108-
}
109-
});

0 commit comments

Comments
 (0)