Skip to content

Commit b9f2435

Browse files
authored
Fix up markdown lists that use * (microsoft#218483)
* Fix up markdown lists that use * Fix microsoft#217946 * Comment
1 parent 7607e75 commit b9f2435

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

src/vs/base/browser/markdownRenderer.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -768,8 +768,8 @@ function completeListItemPattern(list: marked.Tokens.List): marked.Tokens.List |
768768

769769
const previousListItemsText = mergeRawTokenText(list.items.slice(0, -1));
770770

771-
// Grabbing the `- ` or `1. ` off the list item because I can't find a better way to do this
772-
const lastListItemLead = lastListItem.raw.match(/^(\s*(-|\d+\.) +)/)?.[0];
771+
// Grabbing the `- ` or `1. ` or `* ` off the list item because I can't find a better way to do this
772+
const lastListItemLead = lastListItem.raw.match(/^(\s*(-|\d+\.|\*) +)/)?.[0];
773773
if (!lastListItemLead) {
774774
// Is badly formatted
775775
return;

src/vs/base/test/browser/markdownRenderer.test.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -607,6 +607,15 @@ const y = 2;
607607
assert.deepStrictEqual(newTokens, completeTokens);
608608
});
609609

610+
test(`incomplete ${name} in asterisk list`, () => {
611+
const text = `* list item one\n* list item two and ${delimiter}text`;
612+
const tokens = marked.lexer(text);
613+
const newTokens = fillInIncompleteTokens(tokens);
614+
615+
const completeTokens = marked.lexer(text + delimiter);
616+
assert.deepStrictEqual(newTokens, completeTokens);
617+
});
618+
610619
test(`incomplete ${name} in numbered list`, () => {
611620
const text = `1. list item one\n2. list item two and ${delimiter}text`;
612621
const tokens = marked.lexer(text);

0 commit comments

Comments
 (0)