Merge pull request microsoft#149703 from SethFalco/issue-60713

feat: add setting for multi cursor limit

Author: hediet

src/vs/editor/browser/widget/codeEditorWidget.ts

@@ -24,7 +24,6 @@ import { ICommandDelegate } from 'vs/editor/browser/view/viewController';
 import { IContentWidgetData, IOverlayWidgetData, View } from 'vs/editor/browser/view';
 import { ViewUserInputEvents } from 'vs/editor/browser/view/viewUserInputEvents';
 import { ConfigurationChangedEvent, EditorLayoutInfo, IEditorOptions, EditorOption, IComputedEditorOptions, FindComputedEditorOptionValueById, filterValidationDecorations } from 'vs/editor/common/config/editorOptions';
-import { CursorsController } from 'vs/editor/common/cursor/cursor';
 import { CursorColumns } from 'vs/editor/common/core/cursorColumns';
 import { CursorChangeReason, ICursorPositionChangedEvent, ICursorSelectionChangedEvent } from 'vs/editor/common/cursorEvents';
 import { IPosition, Position } from 'vs/editor/common/core/position';
@@ -46,7 +45,7 @@ import { ICommandService } from 'vs/platform/commands/common/commands';
 import { IContextKey, IContextKeyService } from 'vs/platform/contextkey/common/contextkey';
 import { IInstantiationService, ServicesAccessor } from 'vs/platform/instantiation/common/instantiation';
 import { ServiceCollection } from 'vs/platform/instantiation/common/serviceCollection';
-import { INotificationService } from 'vs/platform/notification/common/notification';
+import { INotificationService, Severity } from 'vs/platform/notification/common/notification';
 import { IThemeService, registerThemingParticipant } from 'vs/platform/theme/common/themeService';
 import { IAccessibilityService } from 'vs/platform/accessibility/common/accessibility';
 import { withNullAsUndefined } from 'vs/base/common/types';
@@ -1663,7 +1662,25 @@ export class CodeEditorWidget extends Disposable implements editorBrowser.ICodeE
 					break;
 				case OutgoingViewModelEventKind.CursorStateChanged: {
 					if (e.reachedMaxCursorCount) {
-						this._notificationService.warn(nls.localize('cursors.maximum', "The number of cursors has been limited to {0}.", CursorsController.MAX_CURSOR_COUNT));
+
+						const multiCursorLimit = this.getOption(EditorOption.multiCursorLimit);
+						const message = nls.localize('cursors.maximum', "The number of cursors has been limited to {0}. Consider using [find and replace](https://code.visualstudio.com/docs/editor/codebasics#_find-and-replace) for larger changes.", multiCursorLimit);
+						this._notificationService.prompt(Severity.Warning, message, [
+							{
+								label: 'Find and Replace',
+								run: () => {
+									this._commandService.executeCommand('editor.action.startFindReplaceAction');
+								}
+							},
+							{
+								label: nls.localize('goToSetting', 'Open Settings'),
+								run: () => {
+									this._commandService.executeCommand('workbench.action.openSettings2', {
+										query: 'editor.multiCursorLimit'
+									});
+								}
+							}
+						]);
 					}
 
 					const positions: Position[] = [];

src/vs/editor/common/config/editorOptions.ts

@@ -380,6 +380,10 @@ export interface IEditorOptions {
 	 * Defaults to 'spread'.
 	 */
 	multiCursorPaste?: 'spread' | 'full';
+	/**
+	 * Controls the max number of text cursors that can be in an active editor at once.
+	 */
+	multiCursorLimit?: number;
 	/**
 	 * Configure the editor's accessibility support.
 	 * Defaults to 'auto'. It is best to leave this to 'auto'.
@@ -4729,6 +4733,7 @@ export const enum EditorOption {
 	multiCursorMergeOverlapping,
 	multiCursorModifier,
 	multiCursorPaste,
+	multiCursorLimit,
 	occurrencesHighlight,
 	overviewRulerBorder,
 	overviewRulerLanes,
@@ -5150,6 +5155,12 @@ export const EditorOptions = {
 			markdownDescription: nls.localize('multiCursorPaste', "Controls pasting when the line count of the pasted text matches the cursor count.")
 		}
 	)),
+	multiCursorLimit: register(new EditorIntOption(
+		EditorOption.multiCursorLimit, 'multiCursorLimit', 10000, 1, 100000,
+		{
+			markdownDescription: nls.localize('multiCursorLimit', "Controls the max number of cursors that can be in an active editor at once.")
+		}
+	)),
 	occurrencesHighlight: register(new EditorBooleanOption(
 		EditorOption.occurrencesHighlight, 'occurrencesHighlight', true,
 		{ description: nls.localize('occurrencesHighlight', "Controls whether the editor should highlight semantic symbol occurrences.") }

src/vs/editor/common/cursor/cursor.ts

@@ -24,8 +24,6 @@ import { CursorStateChangedEvent, ViewModelEventsCollector } from 'vs/editor/com
 
 export class CursorsController extends Disposable {
 
-	public static readonly MAX_CURSOR_COUNT = 10000;
-
 	private readonly _model: ITextModel;
 	private _knownModelVersionId: number;
 	private readonly _viewModel: ICursorSimpleModel;
@@ -117,8 +115,9 @@ export class CursorsController extends Disposable {
 
 	public setStates(eventsCollector: ViewModelEventsCollector, source: string | null | undefined, reason: CursorChangeReason, states: PartialCursorState[] | null): boolean {
 		let reachedMaxCursorCount = false;
-		if (states !== null && states.length > CursorsController.MAX_CURSOR_COUNT) {
-			states = states.slice(0, CursorsController.MAX_CURSOR_COUNT);
+		const multiCursorLimit = this.context.cursorConfig.multiCursorLimit;
+		if (states !== null && states.length > multiCursorLimit) {
+			states = states.slice(0, multiCursorLimit);
 			reachedMaxCursorCount = true;
 		}
 

src/vs/editor/common/cursorCommon.ts

@@ -64,6 +64,7 @@ export class CursorConfiguration {
 	public readonly copyWithSyntaxHighlighting: boolean;
 	public readonly multiCursorMergeOverlapping: boolean;
 	public readonly multiCursorPaste: 'spread' | 'full';
+	public readonly multiCursorLimit: number;
 	public readonly autoClosingBrackets: EditorAutoClosingStrategy;
 	public readonly autoClosingQuotes: EditorAutoClosingStrategy;
 	public readonly autoClosingDelete: EditorAutoClosingEditStrategy;
@@ -84,6 +85,7 @@ export class CursorConfiguration {
 			|| e.hasChanged(EditorOption.emptySelectionClipboard)
 			|| e.hasChanged(EditorOption.multiCursorMergeOverlapping)
 			|| e.hasChanged(EditorOption.multiCursorPaste)
+			|| e.hasChanged(EditorOption.multiCursorLimit)
 			|| e.hasChanged(EditorOption.autoClosingBrackets)
 			|| e.hasChanged(EditorOption.autoClosingQuotes)
 			|| e.hasChanged(EditorOption.autoClosingDelete)
@@ -121,6 +123,7 @@ export class CursorConfiguration {
 		this.copyWithSyntaxHighlighting = options.get(EditorOption.copyWithSyntaxHighlighting);
 		this.multiCursorMergeOverlapping = options.get(EditorOption.multiCursorMergeOverlapping);
 		this.multiCursorPaste = options.get(EditorOption.multiCursorPaste);
+		this.multiCursorLimit = options.get(EditorOption.multiCursorLimit);
 		this.autoClosingBrackets = options.get(EditorOption.autoClosingBrackets);
 		this.autoClosingQuotes = options.get(EditorOption.autoClosingQuotes);
 		this.autoClosingDelete = options.get(EditorOption.autoClosingDelete);

src/vs/editor/common/standalone/standaloneEnums.ts

@@ -245,69 +245,70 @@ export enum EditorOption {
 	multiCursorMergeOverlapping = 70,
 	multiCursorModifier = 71,
 	multiCursorPaste = 72,
-	occurrencesHighlight = 73,
-	overviewRulerBorder = 74,
-	overviewRulerLanes = 75,
-	padding = 76,
-	parameterHints = 77,
-	peekWidgetDefaultFocus = 78,
-	definitionLinkOpensInPeek = 79,
-	quickSuggestions = 80,
-	quickSuggestionsDelay = 81,
-	readOnly = 82,
-	renameOnType = 83,
-	renderControlCharacters = 84,
-	renderFinalNewline = 85,
-	renderLineHighlight = 86,
-	renderLineHighlightOnlyWhenFocus = 87,
-	renderValidationDecorations = 88,
-	renderWhitespace = 89,
-	revealHorizontalRightPadding = 90,
-	roundedSelection = 91,
-	rulers = 92,
-	scrollbar = 93,
-	scrollBeyondLastColumn = 94,
-	scrollBeyondLastLine = 95,
-	scrollPredominantAxis = 96,
-	selectionClipboard = 97,
-	selectionHighlight = 98,
-	selectOnLineNumbers = 99,
-	showFoldingControls = 100,
-	showUnused = 101,
-	snippetSuggestions = 102,
-	smartSelect = 103,
-	smoothScrolling = 104,
-	stickyScroll = 105,
-	stickyTabStops = 106,
-	stopRenderingLineAfter = 107,
-	suggest = 108,
-	suggestFontSize = 109,
-	suggestLineHeight = 110,
-	suggestOnTriggerCharacters = 111,
-	suggestSelection = 112,
-	tabCompletion = 113,
-	tabIndex = 114,
-	unicodeHighlighting = 115,
-	unusualLineTerminators = 116,
-	useShadowDOM = 117,
-	useTabStops = 118,
-	wordBreak = 119,
-	wordSeparators = 120,
-	wordWrap = 121,
-	wordWrapBreakAfterCharacters = 122,
-	wordWrapBreakBeforeCharacters = 123,
-	wordWrapColumn = 124,
-	wordWrapOverride1 = 125,
-	wordWrapOverride2 = 126,
-	wrappingIndent = 127,
-	wrappingStrategy = 128,
-	showDeprecated = 129,
-	inlayHints = 130,
-	editorClassName = 131,
-	pixelRatio = 132,
-	tabFocusMode = 133,
-	layoutInfo = 134,
-	wrappingInfo = 135
+	multiCursorLimit = 73,
+	occurrencesHighlight = 74,
+	overviewRulerBorder = 75,
+	overviewRulerLanes = 76,
+	padding = 77,
+	parameterHints = 78,
+	peekWidgetDefaultFocus = 79,
+	definitionLinkOpensInPeek = 80,
+	quickSuggestions = 81,
+	quickSuggestionsDelay = 82,
+	readOnly = 83,
+	renameOnType = 84,
+	renderControlCharacters = 85,
+	renderFinalNewline = 86,
+	renderLineHighlight = 87,
+	renderLineHighlightOnlyWhenFocus = 88,
+	renderValidationDecorations = 89,
+	renderWhitespace = 90,
+	revealHorizontalRightPadding = 91,
+	roundedSelection = 92,
+	rulers = 93,
+	scrollbar = 94,
+	scrollBeyondLastColumn = 95,
+	scrollBeyondLastLine = 96,
+	scrollPredominantAxis = 97,
+	selectionClipboard = 98,
+	selectionHighlight = 99,
+	selectOnLineNumbers = 100,
+	showFoldingControls = 101,
+	showUnused = 102,
+	snippetSuggestions = 103,
+	smartSelect = 104,
+	smoothScrolling = 105,
+	stickyScroll = 106,
+	stickyTabStops = 107,
+	stopRenderingLineAfter = 108,
+	suggest = 109,
+	suggestFontSize = 110,
+	suggestLineHeight = 111,
+	suggestOnTriggerCharacters = 112,
+	suggestSelection = 113,
+	tabCompletion = 114,
+	tabIndex = 115,
+	unicodeHighlighting = 116,
+	unusualLineTerminators = 117,
+	useShadowDOM = 118,
+	useTabStops = 119,
+	wordBreak = 120,
+	wordSeparators = 121,
+	wordWrap = 122,
+	wordWrapBreakAfterCharacters = 123,
+	wordWrapBreakBeforeCharacters = 124,
+	wordWrapColumn = 125,
+	wordWrapOverride1 = 126,
+	wordWrapOverride2 = 127,
+	wrappingIndent = 128,
+	wrappingStrategy = 129,
+	showDeprecated = 130,
+	inlayHints = 131,
+	editorClassName = 132,
+	pixelRatio = 133,
+	tabFocusMode = 134,
+	layoutInfo = 135,
+	wrappingInfo = 136
 }
 
 /**