Skip to content

Commit bc0bdc5

Browse files
authored
Fix hover underline issue on "Modified in" label (microsoft#154386)
Fixes microsoft#154385
1 parent d5379b5 commit bc0bdc5

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

src/vs/workbench/contrib/preferences/browser/media/settingsEditor2.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -351,7 +351,7 @@
351351
font-style: italic;
352352
}
353353

354-
.settings-editor > .settings-body .settings-tree-container .setting-item-contents .setting-item-title > .misc-label .setting-item-overrides:hover,
354+
.settings-editor > .settings-body .settings-tree-container .setting-item-contents .setting-item-title > .misc-label .setting-item-overrides.with-custom-hover:hover,
355355
.settings-editor > .settings-body .settings-tree-container .setting-item-contents .setting-item-title > .misc-label .setting-item-ignored:hover,
356356
.settings-editor > .settings-body .settings-tree-container .setting-item-contents .setting-item-title > .misc-label .setting-item-default-overridden:hover {
357357
text-decoration: underline;

src/vs/workbench/contrib/preferences/browser/settingsEditorSettingIndicators.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,7 @@ export class SettingsTreeIndicatorsLabel implements IDisposable {
139139
// Render inline if we have the flag and there are scope overrides to render,
140140
// or if there is only one scope override to render and no language overrides.
141141
this.scopeOverridesElement.style.display = 'inline';
142+
this.scopeOverridesElement.classList.remove('with-custom-hover');
142143
this.hover?.dispose();
143144

144145
// Just show all the text in the label.
@@ -170,6 +171,7 @@ export class SettingsTreeIndicatorsLabel implements IDisposable {
170171
// show the text in a custom hover only if
171172
// the feature flag isn't on.
172173
this.scopeOverridesElement.style.display = 'inline';
174+
this.scopeOverridesElement.classList.add('with-custom-hover');
173175
const scopeOverridesLabelText = element.isConfigured ?
174176
localize('alsoConfiguredElsewhere', "Also modified elsewhere") :
175177
localize('configuredElsewhere', "Modified elsewhere");

0 commit comments

Comments
 (0)