show private extension indicator in extensions view (microsoft#250277)

Author: sandy081

src/vs/workbench/contrib/extensions/browser/extensionsWidgets.ts

@@ -50,6 +50,7 @@ import { IUriIdentityService } from '../../../../platform/uriIdentity/common/uri
 import { IExplorerService } from '../../files/browser/files.js';
 import { IViewsService } from '../../../services/views/common/viewsService.js';
 import { VIEW_ID as EXPLORER_VIEW_ID } from '../../files/common/files.js';
+import { IExtensionGalleryManifest, IExtensionGalleryManifestService } from '../../../../platform/extensionManagement/common/extensionGalleryManifest.js';
 
 export abstract class ExtensionWidget extends Disposable implements IExtensionContainer {
 	private _extension: IExtension | null = null;
@@ -586,6 +587,7 @@ export class ExtensionPackCountWidget extends ExtensionWidget {
 export class ExtensionKindIndicatorWidget extends ExtensionWidget {
 
 	private element: HTMLElement | undefined;
+	private extensionGalleryManifest: IExtensionGalleryManifest | null = null;
 
 	private readonly disposables = this._register(new DisposableStore());
 
@@ -597,10 +599,18 @@ export class ExtensionKindIndicatorWidget extends ExtensionWidget {
 		@IUriIdentityService private readonly uriIdentityService: IUriIdentityService,
 		@IExplorerService private readonly explorerService: IExplorerService,
 		@IViewsService private readonly viewsService: IViewsService,
+		@IExtensionGalleryManifestService extensionGalleryManifestService: IExtensionGalleryManifestService,
 	) {
 		super();
 		this.render();
 		this._register(toDisposable(() => this.clear()));
+		extensionGalleryManifestService.getExtensionGalleryManifest().then(manifest => {
+			if (this._store.isDisposed) {
+				return;
+			}
+			this.extensionGalleryManifest = manifest;
+			this.render();
+		});
 	}
 
 	private clear(): void {
@@ -611,23 +621,25 @@ export class ExtensionKindIndicatorWidget extends ExtensionWidget {
 	render(): void {
 		this.clear();
 
-		if (this.small) {
-			return;
-		}
-
 		if (!this.extension) {
 			return;
 		}
 
 		if (this.extension?.private) {
 			this.element = append(this.container, $('.extension-kind-indicator'));
-			append(this.element, $('span' + ThemeIcon.asCSSSelector(privateExtensionIcon)));
+			if (!this.small || (this.extensionGalleryManifest?.capabilities.extensions?.includePublicExtensions && this.extensionGalleryManifest?.capabilities.extensions?.includePrivateExtensions)) {
+				append(this.element, $('span' + ThemeIcon.asCSSSelector(privateExtensionIcon)));
+			}
 			if (!this.small) {
 				append(this.element, $('span.private-extension-label', undefined, localize('privateExtension', "Private Extension")));
 			}
 			return;
 		}
 
+		if (!this.small) {
+			return;
+		}
+
 		const location = this.extension.resourceExtension?.location ?? (this.extension.local?.source === 'resource' ? this.extension.local?.location : undefined);
 		if (!location) {
 			return;

src/vs/workbench/contrib/extensions/browser/media/extension.css

@@ -92,7 +92,7 @@
 
 .extension-list-item > .details > .header-container > .header .extension-kind-indicator {
 	font-size: 80%;
-	margin-left: 2px;
+	margin-left: 4px;
 }
 
 .extension-list-item > .details > .header-container > .header > .install-count:not(:empty) {