Fix vscode-jupyter#13522. Clear attachment if it does not exit. (microsoft#186578)

rebornix · web-flow · commit bce3304e9841 · 2023-06-29T09:41:01.000+10:00
Fix microsoft#184630. Clear attachment if it does not exit.
diff --git a/extensions/ipynb/src/notebookAttachmentCleaner.ts b/extensions/ipynb/src/notebookAttachmentCleaner.ts
@@ -232,7 +232,7 @@ export class AttachmentCleaner implements vscode.CodeActionProvider {
 		if (cell.index > -1 && !objectEquals(markdownAttachmentsInUse, cell.metadata.attachments)) {
 			const updateMetadata: { [key: string]: any } = deepClone(cell.metadata);
 			if (Object.keys(markdownAttachmentsInUse).length === 0) {
-				updateMetadata.attachments = null;
+				updateMetadata.attachments = undefined;
 			} else {
 				updateMetadata.attachments = markdownAttachmentsInUse;
 			}

Original file line number	Diff line number	Diff line change
`@@ -232,7 +232,7 @@ export class AttachmentCleaner implements vscode.CodeActionProvider {`
`232`	`232`	`if (cell.index > -1 && !objectEquals(markdownAttachmentsInUse, cell.metadata.attachments)) {`
`233`	`233`	`const updateMetadata: { [key: string]: any } = deepClone(cell.metadata);`
`234`	`234`	`if (Object.keys(markdownAttachmentsInUse).length === 0) {`
`235`		`- updateMetadata.attachments = null;`
	`235`	`+ updateMetadata.attachments = undefined;`
`236`	`236`	`} else {`
`237`	`237`	`updateMetadata.attachments = markdownAttachmentsInUse;`
`238`	`238`	`}`