Merge pull request microsoft#185345 from microsoft/tyriar/codeql_suppress

Tyriar · web-flow · commit bda8ac3f2f57 · 2023-06-16T09:07:19.000-07:00
Suppress UI label-related codeql report
diff --git a/src/vs/workbench/contrib/terminal/browser/terminalProfileQuickpick.ts b/src/vs/workbench/contrib/terminal/browser/terminalProfileQuickpick.ts
@@ -266,7 +266,7 @@ export class TerminalProfileQuickpick {
 			}
 			const argsString = profile.args.map(e => {
 				if (e.includes(' ')) {
-					return `"${e.replace(/"/g, '\\"')}"`;
+					return `"${e.replace(/"/g, '\\"')}"`; // CodeQL [SM02383] js/incomplete-sanitization This is only used as a label on the UI so this isn't a problem
 				}
 				return e;
 			}).join(' ');

Original file line number	Diff line number	Diff line change
`@@ -266,7 +266,7 @@ export class TerminalProfileQuickpick {`
`266`	`266`	`}`
`267`	`267`	`const argsString = profile.args.map(e => {`
`268`	`268`	`if (e.includes(' ')) {`
`269`		- return `"${e.replace(/"/g, '\\"')}"`;
	`269`	+ return `"${e.replace(/"/g, '\\"')}"`; // CodeQL [SM02383] js/incomplete-sanitization This is only used as a label on the UI so this isn't a problem
`270`	`270`	`}`
`271`	`271`	`return e;`
`272`	`272`	`}).join(' ');`