notifications - set aria label of toasts to match as if it was focused (fix microsoft#135638)

Author: bpasero

src/vs/workbench/browser/parts/notifications/notificationsCenter.ts

@@ -157,7 +157,9 @@ export class NotificationsCenter extends Themable implements INotificationsCente
 		notificationsToolBar.push(hideAllAction, { icon: true, label: false, keybinding: this.getKeybindingLabel(hideAllAction) });
 
 		// Notifications List
-		this.notificationsList = this.instantiationService.createInstance(NotificationsList, this.notificationsCenterContainer, {});
+		this.notificationsList = this.instantiationService.createInstance(NotificationsList, this.notificationsCenterContainer, {
+			widgetAriaLabel: localize('notificationsCenterWidgetAriaLabel', "Notifications Center")
+		});
 		this.container.appendChild(this.notificationsCenterContainer);
 	}
 

src/vs/workbench/browser/parts/notifications/notificationsList.ts

@@ -20,7 +20,12 @@ import { IContextMenuService } from 'vs/platform/contextview/browser/contextView
 import { assertIsDefined, assertAllDefined } from 'vs/base/common/types';
 import { Codicon } from 'vs/base/common/codicons';
 
+export interface INotificationsListOptions extends IListOptions<INotificationViewItem> {
+	widgetAriaLabel?: string;
+}
+
 export class NotificationsList extends Themable {
+
 	private listContainer: HTMLElement | undefined;
 	private list: WorkbenchList<INotificationViewItem> | undefined;
 	private listDelegate: NotificationsListDelegate | undefined;
@@ -29,7 +34,7 @@ export class NotificationsList extends Themable {
 
 	constructor(
 		private readonly container: HTMLElement,
-		private readonly options: IListOptions<INotificationViewItem>,
+		private readonly options: INotificationsListOptions,
 		@IInstantiationService private readonly instantiationService: IInstantiationService,
 		@IThemeService themeService: IThemeService,
 		@IContextMenuService private readonly contextMenuService: IContextMenuService
@@ -75,14 +80,15 @@ export class NotificationsList extends Themable {
 
 		// List
 		const listDelegate = this.listDelegate = new NotificationsListDelegate(this.listContainer);
+		const options = this.options;
 		const list = this.list = <WorkbenchList<INotificationViewItem>>this._register(this.instantiationService.createInstance(
 			WorkbenchList,
 			'NotificationsList',
 			this.listContainer,
 			listDelegate,
 			[renderer],
 			{
-				...this.options,
+				...options,
 				setRowLineHeight: false,
 				horizontalScrolling: false,
 				overrideStyles: {
@@ -97,7 +103,7 @@ export class NotificationsList extends Themable {
 						return localize('notificationWithSourceAriaLabel', "{0}, source: {1}, notification", element.message.raw, element.source);
 					},
 					getWidgetAriaLabel(): string {
-						return localize('notificationsList', "Notifications List");
+						return options.widgetAriaLabel ?? localize('notificationsList', "Notifications List");
 					},
 					getRole(): string {
 						return 'dialog'; // https://github.com/microsoft/vscode/issues/82728

src/vs/workbench/browser/parts/notifications/notificationsToasts.ts

@@ -4,6 +4,7 @@
  *--------------------------------------------------------------------------------------------*/
 
 import 'vs/css!./media/notificationsToasts';
+import { localize } from 'vs/nls';
 import { INotificationsModel, NotificationChangeType, INotificationChangeEvent, INotificationViewItem, NotificationViewItemContentChangeKind } from 'vs/workbench/common/notifications';
 import { IDisposable, dispose, toDisposable, DisposableStore } from 'vs/base/common/lifecycle';
 import { isAncestor, addDisposableListener, EventType, Dimension, scheduleAtNextAnimationFrame } from 'vs/base/browser/dom';
@@ -183,7 +184,14 @@ export class NotificationsToasts extends Themable implements INotificationsToast
 
 		// Create toast with item and show
 		const notificationList = this.instantiationService.createInstance(NotificationsList, notificationToast, {
-			verticalScrollMode: ScrollbarVisibility.Hidden
+			verticalScrollMode: ScrollbarVisibility.Hidden,
+			widgetAriaLabel: (() => {
+				if (!item.source) {
+					return localize('notificationAriaLabel', "{0}, notification", item.message.raw);
+				}
+
+				return localize('notificationWithSourceAriaLabel', "{0}, source: {1}, notification", item.message.raw, item.source);
+			})()
 		});
 		itemDisposables.add(notificationList);