Merge pull request microsoft#188968 from microsoft/merogge/focus-last-r

meganrogge · web-flow · commit c130505d4f37 · 2023-07-26T12:38:27.000-07:00
fix off by 1 error so last chat response can be reached
diff --git a/src/vs/workbench/contrib/chat/browser/chatWidget.ts b/src/vs/workbench/contrib/chat/browser/chatWidget.ts
@@ -189,7 +189,7 @@ export class ChatWidget extends Disposable implements IChatWidget {
 			return;
 		}
 		const indexToFocus = type === 'next' ? targetIndex + 1 : targetIndex - 1;
-		if (indexToFocus < 0 || indexToFocus === responseItems.length - 1) {
+		if (indexToFocus < 0 || indexToFocus > responseItems.length - 1) {
 			return;
 		}
 		this.focus(responseItems[indexToFocus]);

Original file line number	Diff line number	Diff line change
`@@ -189,7 +189,7 @@ export class ChatWidget extends Disposable implements IChatWidget {`
`189`	`189`	`return;`
`190`	`190`	`}`
`191`	`191`	`const indexToFocus = type === 'next' ? targetIndex + 1 : targetIndex - 1;`
`192`		`- if (indexToFocus < 0 \|\| indexToFocus === responseItems.length - 1) {`
	`192`	`+ if (indexToFocus < 0 \|\| indexToFocus > responseItems.length - 1) {`
`193`	`193`	`return;`
`194`	`194`	`}`
`195`	`195`	`this.focus(responseItems[indexToFocus]);`