Skip to content

Commit c1eab19

Browse files
authored
Use tmp dir for extension extract location (microsoft#181893)
microsoft#181671 use tmp path for extracted extensions
1 parent 618dc85 commit c1eab19

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/vs/platform/extensionManagement/node/extensionManagementService.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import { IStringDictionary } from 'vs/base/common/collections';
1010
import { toErrorMessage } from 'vs/base/common/errorMessage';
1111
import { getErrorMessage } from 'vs/base/common/errors';
1212
import { Emitter } from 'vs/base/common/event';
13+
import { randomPath } from 'vs/base/common/extpath';
1314
import { Disposable } from 'vs/base/common/lifecycle';
1415
import { ResourceSet } from 'vs/base/common/map';
1516
import { Schemas } from 'vs/base/common/network';
@@ -414,6 +415,7 @@ export class ExtensionsScanner extends Disposable {
414415
@IFileService private readonly fileService: IFileService,
415416
@IExtensionsScannerService private readonly extensionsScannerService: IExtensionsScannerService,
416417
@IExtensionsProfileScannerService private readonly extensionsProfileScannerService: IExtensionsProfileScannerService,
418+
@INativeEnvironmentService private readonly environmentService: INativeEnvironmentService,
417419
@ILogService private readonly logService: ILogService,
418420
) {
419421
super();
@@ -456,7 +458,7 @@ export class ExtensionsScanner extends Disposable {
456458

457459
async extractUserExtension(extensionKey: ExtensionKey, zipPath: string, metadata: Metadata, token: CancellationToken): Promise<ILocalExtension> {
458460
const folderName = extensionKey.toString();
459-
const tempPath = path.join(this.extensionsScannerService.userExtensionsLocation.fsPath, `.${generateUuid()}`);
461+
const tempPath = randomPath(this.environmentService.tmpDir.fsPath);
460462
const extensionPath = path.join(this.extensionsScannerService.userExtensionsLocation.fsPath, folderName);
461463

462464
try {

0 commit comments

Comments
 (0)