Skip to content

Commit c22b9fb

Browse files
authored
Merge pull request microsoft#168853 from microsoft/sandy081/peaceful-sheep
Revert "only renderBody when view is visible/expanded (microsoft#165187)"
2 parents cf34d7c + a8e8c39 commit c22b9fb

File tree

1 file changed

+1
-13
lines changed

1 file changed

+1
-13
lines changed

src/vs/base/browser/ui/splitview/paneview.ts

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ export abstract class Pane extends Disposable implements IView {
5858

5959
private expandedSize: number | undefined = undefined;
6060
private _headerVisible = true;
61-
private _bodyRendered = false;
6261
private _minimumBodySize: number;
6362
private _maximumBodySize: number;
6463
private _ariaHeaderLabel: string;
@@ -159,11 +158,6 @@ export abstract class Pane extends Disposable implements IView {
159158
this.updateHeader();
160159

161160
if (expanded) {
162-
if (!this._bodyRendered) {
163-
this.renderBody(this.body);
164-
this._bodyRendered = true;
165-
}
166-
167161
if (typeof this.animationTimer === 'number') {
168162
clearTimeout(this.animationTimer);
169163
}
@@ -255,13 +249,7 @@ export abstract class Pane extends Disposable implements IView {
255249
});
256250

257251
this.body = append(this.element, $('.pane-body'));
258-
259-
// Only render the body if it will be visible
260-
// Otherwise, render it when the pane is expanded
261-
if (!this._bodyRendered && this.isExpanded()) {
262-
this.renderBody(this.body);
263-
this._bodyRendered = true;
264-
}
252+
this.renderBody(this.body);
265253

266254
if (!this.isExpanded()) {
267255
this.body.remove();

0 commit comments

Comments
 (0)