Skip to content

Commit c3275e4

Browse files
committed
changes from review
1 parent 0e8491b commit c3275e4

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

src/vs/workbench/contrib/inlineChat/browser/inlineChatController.ts

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -195,9 +195,15 @@ export class InlineChatController implements IEditorContribution {
195195

196196
private _showWidget(initialRender: boolean = false) {
197197
assertType(this._activeSession);
198-
const selectionRange = this._activeSession.wholeRange.value;
199-
const widgetPosition = this._strategy?.getWidgetPosition(initialRender, selectionRange);
200-
this._zone.value.show(widgetPosition ?? selectionRange.getEndPosition());
198+
assertType(this._strategy);
199+
200+
let widgetPosition: Position | null;
201+
if (initialRender) {
202+
widgetPosition = this._editor.getPosition();
203+
} else {
204+
widgetPosition = this._strategy.getWidgetPosition();
205+
}
206+
this._zone.value.show((widgetPosition ?? this._zone.value.position) ?? this._activeSession.wholeRange.value.getEndPosition());
201207
}
202208

203209
protected async _nextState(state: State, options: InlineChatRunOptions | undefined): Promise<void> {
@@ -241,14 +247,14 @@ export class InlineChatController implements IEditorContribution {
241247

242248
switch (session.editMode) {
243249
case EditMode.Live:
244-
this._strategy = this._instaService.createInstance(LiveStrategy, this._editor, session, this._zone.value.widget);
250+
this._strategy = this._instaService.createInstance(LiveStrategy, session, this._editor, this._zone.value.widget);
245251
break;
246252
case EditMode.Preview:
247-
this._strategy = this._instaService.createInstance(PreviewStrategy, this._editor, session, this._zone.value.widget);
253+
this._strategy = this._instaService.createInstance(PreviewStrategy, session, this._zone.value.widget);
248254
break;
249255
case EditMode.LivePreview:
250256
default:
251-
this._strategy = this._instaService.createInstance(LivePreviewStrategy, this._editor, session, this._zone.value.widget);
257+
this._strategy = this._instaService.createInstance(LivePreviewStrategy, session, this._editor, this._zone.value.widget);
252258
break;
253259
}
254260

0 commit comments

Comments
 (0)