Skip to content

Commit c3f40b9

Browse files
authored
Switch from setupCustomHover to hoverService (microsoft#166500)
Ref microsoft#159088 By switching to hoverService, we get to customize the hover widget more for the Settings editor indicators.
1 parent 9740d4b commit c3f40b9

File tree

4 files changed

+142
-102
lines changed

4 files changed

+142
-102
lines changed

src/vs/base/common/async.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -819,7 +819,7 @@ export class IntervalTimer implements IDisposable {
819819
}
820820
}
821821

822-
export class RunOnceScheduler {
822+
export class RunOnceScheduler implements IDisposable {
823823

824824
protected runner: ((...args: unknown[]) => void) | null;
825825

src/vs/workbench/contrib/preferences/browser/media/settingsEditor2.css

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -344,6 +344,7 @@
344344
overflow: hidden;
345345
text-overflow: ellipsis;
346346
display: inline-block; /* size to contents for hover to show context button */
347+
padding-bottom: 2px; /* so that focus outlines wrap around nicely for indicators, especially ones with codicons */
347348
}
348349

349350
.settings-editor > .settings-body .settings-tree-container .setting-item-contents .setting-item-modified-indicator {
@@ -368,7 +369,7 @@
368369
bottom: 23px;
369370
}
370371

371-
.settings-editor > .settings-body .settings-tree-container .setting-item-contents .setting-item-title > .misc-label {
372+
.settings-editor > .settings-body .settings-tree-container .setting-item-contents .setting-item-title > .setting-indicators-container {
372373
font-style: italic;
373374
}
374375

@@ -379,8 +380,8 @@
379380
opacity: 0.9;
380381
}
381382

382-
.settings-editor > .settings-body .settings-tree-container .setting-item-contents .setting-item-title > .misc-label .setting-indicator:hover {
383-
text-decoration: underline;
383+
.settings-editor > .settings-body .settings-tree-container .setting-item-contents .setting-item-title > .setting-indicators-container .setting-indicator {
384+
padding-bottom: 2px;
384385
}
385386

386387
.settings-editor > .settings-body .settings-tree-container .setting-item-contents .setting-item-title .codicon {

0 commit comments

Comments
 (0)