Revert "Centralize query parameter cleaning /cc @bpasero and @aeschli"

This reverts commit 0b87133.

Author: lramos15

src/vs/base/common/resources.ts

@@ -195,9 +195,7 @@ export class ExtUri implements IExtUri {
 	}
 
 	extname(resource: URI): string {
-		const resourceExt = paths.posix.extname(resource.path);
-		const queryStringLocation = resourceExt.indexOf('?');
-		return queryStringLocation !== -1 ? resourceExt.substr(0, queryStringLocation) : resourceExt;
+		return paths.posix.extname(resource.path);
 	}
 
 	dirname(resource: URI): URI {

src/vs/base/test/common/resources.test.ts

@@ -6,7 +6,7 @@ import * as assert from 'assert';
 import { toSlashes } from 'vs/base/common/extpath';
 import { posix, win32 } from 'vs/base/common/path';
 import { isWindows } from 'vs/base/common/platform';
-import { addTrailingPathSeparator, basename, dirname, distinctParents, extname, extUri, extUriIgnorePathCase, hasTrailingPathSeparator, isAbsolutePath, joinPath, normalizePath, relativePath, removeTrailingPathSeparator, resolvePath } from 'vs/base/common/resources';
+import { addTrailingPathSeparator, basename, dirname, distinctParents, extUri, extUriIgnorePathCase, hasTrailingPathSeparator, isAbsolutePath, joinPath, normalizePath, relativePath, removeTrailingPathSeparator, resolvePath } from 'vs/base/common/resources';
 import { URI } from 'vs/base/common/uri';
 
 
@@ -429,11 +429,4 @@ suite('Resources', () => {
 		assert.strictEqual(extUriIgnorePathCase.isEqualOrParent(fileURI7, fileURI6), true, '19');
 		assert.strictEqual(extUriIgnorePathCase.isEqualOrParent(fileURI7, fileURI5), false, '20');
 	});
-
-	test('query parameters stripped from extname', () => {
-		const uriWithQueryParam = URI.file('/test/project/test.txt?q=1');
-		const uriWithoutQueryParam = URI.file('/test/project/test.txt');
-		assert.strictEqual(extname(uriWithQueryParam), '.txt');
-		assert.strictEqual(extname(uriWithoutQueryParam), '.txt');
-	});
 });

src/vs/workbench/browser/parts/editor/editorGroupView.ts

@@ -631,6 +631,9 @@ export class EditorGroupView extends Themable implements IEditorGroupView {
 		const path = resource ? resource.scheme === Schemas.file ? resource.fsPath : resource.path : undefined;
 		if (resource && path) {
 			let resourceExt = extname(resource);
+			// Remove query parameters from the resource extension
+			const queryStringLocation = resourceExt.indexOf('?');
+			resourceExt = queryStringLocation !== -1 ? resourceExt.substr(0, queryStringLocation) : resourceExt;
 			descriptor['resource'] = { mimeType: guessMimeTypes(resource).join(', '), scheme: resource.scheme, ext: resourceExt, path: hash(path) };
 
 			/* __GDPR__FRAGMENT__

src/vs/workbench/contrib/telemetry/browser/telemetry.contribution.ts

@@ -194,7 +194,10 @@ export class TelemetryContribution extends Disposable implements IWorkbenchContr
 	}
 
 	private getTelemetryData(resource: URI, reason?: number): TelemetryData {
-		const ext = extname(resource);
+		let ext = extname(resource);
+		// Remove query parameters from the resource extension
+		const queryStringLocation = ext.indexOf('?');
+		ext = queryStringLocation !== -1 ? ext.substr(0, queryStringLocation) : ext;
 		const fileName = basename(resource);
 		const path = resource.scheme === Schemas.file ? resource.fsPath : resource.path;
 		const telemetryData = {