Clear Diff Widget model before disposing the model

DonJayamanne · DonJayamanne · commit c655326fd2a3 · 2024-08-26T17:16:02.000+10:00
diff --git a/src/vs/workbench/contrib/notebook/browser/diff/diffComponents.ts b/src/vs/workbench/contrib/notebook/browser/diff/diffComponents.ts
@@ -1815,6 +1815,10 @@ export class ModifiedElement extends AbstractElementRenderer {
 	}
 
 	override dispose() {
+		// The editor isn't disposed yet, it can be re-used.
+		// However the model can be disposed before the editor & that causes issues.
+		this._editor!.setModel(null);
+
 		if (this._editor && this._editorViewStateChanged) {
 			this.cell.saveSpirceEditorViewState(this._editor.saveViewState());
 		}

Original file line number	Diff line number	Diff line change
`@@ -1815,6 +1815,10 @@ export class ModifiedElement extends AbstractElementRenderer {`
`1815`	`1815`	`}`
`1816`	`1816`
`1817`	`1817`	`override dispose() {`
	`1818`	`+ // The editor isn't disposed yet, it can be re-used.`
	`1819`	`+ // However the model can be disposed before the editor & that causes issues.`
	`1820`	`+ this._editor!.setModel(null);`
	`1821`	`+`
`1818`	`1822`	`if (this._editor && this._editorViewStateChanged) {`
`1819`	`1823`	`this.cell.saveSpirceEditorViewState(this._editor.saveViewState());`
`1820`	`1824`	`}`