fix issue related to no prompts showing up and always keep the docs item in the list

Author: legomushroom

src/vs/workbench/contrib/chat/browser/actions/chatAttachPromptAction/chatAttachPromptAction.ts

@@ -5,7 +5,6 @@
 
 import { CHAT_CATEGORY } from '../chatActions.js';
 import { localize2 } from '../../../../../../nls.js';
-import { showHowToCreateLink } from './dialogs/showHowToCreate.js';
 import { Action2 } from '../../../../../../platform/actions/common/actions.js';
 import { IPromptsService } from '../../../common/promptSyntax/service/types.js';
 import { ILabelService } from '../../../../../../platform/label/common/label.js';
@@ -53,19 +52,13 @@ export class AttachPromptAction extends Action2 {
 		// find all prompt files in the user workspace
 		const promptFiles = await promptsService.listPromptFiles();
 
-		// if no prompt files found, show instructions on how to create one
-		if (promptFiles.length === 0) {
-			return await showHowToCreateLink(openerService, quickInputService);
-		}
-
-		await askToSelectPrompt(
-			{
-				...options,
-				promptFiles,
-				labelService,
-				viewsService,
-				openerService,
-				quickInputService,
-			});
+		await askToSelectPrompt({
+			...options,
+			promptFiles,
+			labelService,
+			viewsService,
+			openerService,
+			quickInputService,
+		});
 	}
 }

src/vs/workbench/contrib/chat/browser/actions/chatAttachPromptAction/dialogs/askToSelectPrompt.ts

@@ -11,6 +11,7 @@ import { IChatAttachPromptActionOptions } from '../chatAttachPromptAction.js';
 import { IPromptPath } from '../../../../common/promptSyntax/service/types.js';
 import { DisposableStore } from '../../../../../../../base/common/lifecycle.js';
 import { dirname, extUri } from '../../../../../../../base/common/resources.js';
+import { DOCUMENTATION_URL } from '../../../../common/promptSyntax/constants.js';
 import { isLinux, isWindows } from '../../../../../../../base/common/platform.js';
 import { ILabelService } from '../../../../../../../platform/label/common/label.js';
 import { IOpenerService } from '../../../../../../../platform/opener/common/opener.js';
@@ -50,6 +51,20 @@ export interface ISelectPromptOptions {
 	readonly quickInputService: IQuickInputService;
 }
 
+/**
+ * A special quick pick item that links to the documentation.
+ */
+const DOCS_OPTION: WithUriValue<IQuickPickItem> = {
+	type: 'item',
+	label: localize(
+		'commands.prompts.use.select-dialog.docs-label',
+		'Learn how to create reusable prompts',
+	),
+	description: DOCUMENTATION_URL,
+	tooltip: DOCUMENTATION_URL,
+	value: URI.parse(DOCUMENTATION_URL),
+};
+
 /**
  * Shows the prompt selection dialog to the user that allows to select a prompt file(s).
  *
@@ -61,16 +76,15 @@ export const askToSelectPrompt = async (
 ): Promise<void> => {
 	const { promptFiles, resource, quickInputService, labelService } = options;
 
-	// a sanity check - this function must be used only if there are prompt files to show
-	assert(
-		promptFiles.length > 0,
-		'Prompt files list must not be empty.',
-	);
-
 	const fileOptions = promptFiles.map(({ uri }) => {
 		return createPickItem(uri, labelService);
 	});
 
+	/**
+	 * Add a link to the documentation to the end of prompts list.
+	 */
+	fileOptions.push(DOCS_OPTION);
+
 	// if a resource is provided, create an `activeItem` for it to pre-select
 	// it in the UI, and sort the list so the active item appears at the top
 	let activeItem: WithUriValue<IQuickPickItem> | undefined;
@@ -101,6 +115,13 @@ export const askToSelectPrompt = async (
 		});
 	}
 
+	/**
+	 * If still no active item present, fall back to the first item in the list.
+	 */
+	if (!activeItem) {
+		activeItem = fileOptions[0];
+	}
+
 	// otherwise show the prompt file selection dialog
 	const { openerService } = options;
 
@@ -129,8 +150,17 @@ export const askToSelectPrompt = async (
 			const { selectedItems } = quickPick;
 			const { alt, ctrlCmd } = quickPick.keyMods;
 
+			// sanity check to confirm our expectations
+			assert(
+				selectedItems.length === 1,
+				`Only one item can be accepted, got '${selectedItems.length}'.`,
+			);
+
+			// whether user selected the docs link option
+			const docsSelected = (selectedItems[0] === DOCS_OPTION);
+
 			// if `super` key was pressed, open the selected prompt file(s)
-			if (ctrlCmd) {
+			if (ctrlCmd || docsSelected) {
 				return await openFiles(selectedItems, openerService);
 			}