Skip to content

Commit c6f126b

Browse files
committed
Fix notebook serializer activation
1 parent 503e4bc commit c6f126b

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

src/vs/workbench/contrib/notebook/browser/services/notebookServiceImpl.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,13 +116,14 @@ export class NotebookProviderInfoStore extends Disposable {
116116
if (!existing.extension && extension.description.isBuiltin && builtins.find(builtin => builtin.id === notebookContribution.type)) {
117117
// we are registering an extension which is using the same view type which is already cached
118118
builtinProvidersFromCache.get(notebookContribution.type)?.dispose();
119-
implicitActivationEvents.push(`onNotebookSerializer:${notebookContribution.type}`);
120119
} else {
121120
extension.collector.error(`Notebook type '${notebookContribution.type}' already used`);
122121
continue;
123122
}
124123
}
125124

125+
implicitActivationEvents.push(`onNotebookSerializer:${notebookContribution.type}`);
126+
126127
this.add(new NotebookProviderInfo({
127128
extension: extension.description.identifier,
128129
id: notebookContribution.type,

src/vs/workbench/services/extensions/common/abstractExtensionService.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1226,6 +1226,7 @@ export abstract class AbstractExtensionService extends Disposable implements IEx
12261226
}
12271227
this._combineImplicitExtensionActivationEvents();
12281228
perf.mark('code/didHandleExtensionPoints');
1229+
this._registry.set(availableExtensions);
12291230
}
12301231

12311232
private _combineImplicitExtensionActivationEvents() {

0 commit comments

Comments
 (0)