Provider API fixes

Author: osortega

src/vs/workbench/api/browser/mainThreadChatSessions.ts

@@ -5,6 +5,7 @@
 
 import { CancellationToken } from '../../../base/common/cancellation.js';
 import { Disposable, DisposableMap } from '../../../base/common/lifecycle.js';
+import { URI, UriComponents } from '../../../base/common/uri.js';
 import { ILogService } from '../../../platform/log/common/log.js';
 import { IChatSessionContent, IChatSessionsProvider, IChatSessionsService } from '../../contrib/chat/common/chatSessionsService.js';
 import { extHostNamedCustomer, IExtHostContext } from '../../services/extensions/common/extHostCustomers.js';
@@ -35,7 +36,12 @@ export class MainThreadChatSessions extends Disposable implements MainThreadChat
 
 		try {
 			// Get all results as an array from the RPC call
-			return await proxy.$provideChatSessions(handle, token);
+			const sessions = await proxy.$provideChatSessions(handle, token);
+			return sessions.map(session => ({
+				...session,
+				uri: URI.revive(session.uri),
+				iconPath: session.iconPath ? this._reviveIconPath(session.iconPath) : undefined
+			}));
 		} catch (error) {
 			this._logService.error('Error providing chat sessions:', error);
 		}
@@ -45,4 +51,27 @@ export class MainThreadChatSessions extends Disposable implements MainThreadChat
 	$unregisterChatSessionsProvider(handle: number): void {
 		this._registrations.deleteAndDispose(handle);
 	}
+
+
+	private _reviveIconPath(
+		iconPath: UriComponents | { light: UriComponents; dark: UriComponents } | { id: string; color?: { id: string } | undefined })
+		: IChatSessionContent['iconPath'] {
+		if (!iconPath) {
+			return undefined;
+		}
+
+		// Handle ThemeIcon (has id property)
+		if (typeof iconPath === 'object' && 'id' in iconPath) {
+			return iconPath; // ThemeIcon doesn't need conversion
+		}
+
+		// Handle light/dark theme icons
+		if (typeof iconPath === 'object' && ('light' in iconPath && 'dark' in iconPath)) {
+			return {
+				light: URI.revive(iconPath.light),
+				dark: URI.revive(iconPath.dark)
+			};
+		}
+		return undefined;
+	}
 }

src/vs/workbench/contrib/chat/common/chatSessionsService.ts

@@ -8,13 +8,16 @@ import { CancellationToken } from '../../../../base/common/cancellation.js';
 import { ILogService } from '../../../../platform/log/common/log.js';
 import { createDecorator } from '../../../../platform/instantiation/common/instantiation.js';
 import { InstantiationType, registerSingleton } from '../../../../platform/instantiation/common/extensions.js';
-import { IconPath } from '../../../../editor/common/languages.js';
-import { UriComponents } from '../../../../base/common/uri.js';
+import { URI } from '../../../../base/common/uri.js';
+import { ThemeIcon } from '../../../../base/common/themables.js';
 
 export interface IChatSessionContent {
-	uri: UriComponents;
+	uri: URI;
 	label: string;
-	iconPath?: IconPath;
+	iconPath?: URI | {
+		light: URI;
+		dark: URI;
+	} | ThemeIcon;
 }
 
 export interface IChatSessionsProvider {

src/vscode-dts/vscode.proposed.chatSessionsProvider.d.ts

@@ -8,6 +8,10 @@ declare module 'vscode' {
 	 * Provides a list of chat sessions
 	 */
 	export interface ChatSessionsProvider extends Disposable {
+		/**
+		 * Type to identify providers.
+		 */
+		readonly chatSessionType: string;
 
 		/**
 		 * Fired when chat sessions change.