Zoom level indicator always reset to level 1 (microsoft#204019) (microsoft#204083)

bpasero · web-flow · commit c8599d69e2b3 · 2024-02-05T10:45:28.000+01:00
diff --git a/src/vs/workbench/electron-sandbox/actions/windowActions.ts b/src/vs/workbench/electron-sandbox/actions/windowActions.ts
@@ -84,7 +84,7 @@ abstract class BaseZoomAction extends Action2 {
 
 		let level: number;
 		if (typeof levelOrReset === 'number') {
-			level = levelOrReset;
+			level = Math.round(levelOrReset); // prevent fractional zoom levels
 		} else {
 
 			// reset to 0 when we apply to all windows
@@ -103,8 +103,6 @@ abstract class BaseZoomAction extends Action2 {
 			}
 		}
 
-		level = Math.round(level); // when reaching smallest zoom, prevent fractional zoom levels
-
 		if (level > MAX_ZOOM_LEVEL || level < MIN_ZOOM_LEVEL) {
 			return; // https://github.com/microsoft/vscode/issues/48357
 		}

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ abstract class BaseZoomAction extends Action2 {`
`84`	`84`
`85`	`85`	`let level: number;`
`86`	`86`	`if (typeof levelOrReset === 'number') {`
`87`		`- level = levelOrReset;`
	`87`	`+ level = Math.round(levelOrReset); // prevent fractional zoom levels`
`88`	`88`	`} else {`
`89`	`89`
`90`	`90`	`// reset to 0 when we apply to all windows`
`@@ -103,8 +103,6 @@ abstract class BaseZoomAction extends Action2 {`
`103`	`103`	`}`
`104`	`104`	`}`
`105`	`105`
`106`		`- level = Math.round(level); // when reaching smallest zoom, prevent fractional zoom levels`
`107`		`-`
`108`	`106`	`if (level > MAX_ZOOM_LEVEL \|\| level < MIN_ZOOM_LEVEL) {`
`109`	`107`	`return; // https://github.com/microsoft/vscode/issues/48357`
`110`	`108`	`}`