Get rid of extension icon fallback for chat providers, to fix codicon for copilot (microsoft#196651)

Author: roblourens

src/vs/workbench/api/browser/mainThreadChat.ts

@@ -70,9 +70,8 @@ export class MainThreadChat extends Disposable implements MainThreadChatShape {
 					return undefined;
 				}
 
-				const responderAvatarIconUri = session.responderAvatarIconUri ?
-					URI.revive(session.responderAvatarIconUri) :
-					registration.extensionIcon;
+				const responderAvatarIconUri = session.responderAvatarIconUri &&
+					URI.revive(session.responderAvatarIconUri);
 
 				const emitter = new Emitter<any>();
 				this._stateEmitters.set(session.id, emitter);

src/vs/workbench/contrib/chat/browser/chatContributionServiceImpl.ts

@@ -5,14 +5,13 @@
 
 import { Codicon } from 'vs/base/common/codicons';
 import { DisposableStore, IDisposable } from 'vs/base/common/lifecycle';
-import * as resources from 'vs/base/common/resources';
 import { localize, localize2 } from 'vs/nls';
 import { registerAction2 } from 'vs/platform/actions/common/actions';
 import { ContextKeyExpr } from 'vs/platform/contextkey/common/contextkey';
 import { SyncDescriptor } from 'vs/platform/instantiation/common/descriptors';
 import { Registry } from 'vs/platform/registry/common/platform';
 import { ViewPaneContainer } from 'vs/workbench/browser/parts/views/viewPaneContainer';
-import { Extensions as WorkbenchExtensions, IWorkbenchContribution, IWorkbenchContributionsRegistry } from 'vs/workbench/common/contributions';
+import { IWorkbenchContribution, IWorkbenchContributionsRegistry, Extensions as WorkbenchExtensions } from 'vs/workbench/common/contributions';
 import { IViewContainersRegistry, IViewDescriptor, IViewsRegistry, ViewContainer, ViewContainerLocation, Extensions as ViewExtensions } from 'vs/workbench/common/views';
 import { getHistoryAction, getOpenChatEditorAction } from 'vs/workbench/contrib/chat/browser/actions/chatActions';
 import { getClearAction } from 'vs/workbench/contrib/chat/browser/actions/chatClearActions';
@@ -79,13 +78,7 @@ export class ChatExtensionPointHandler implements IWorkbenchContribution {
 				const extensionDisposable = new DisposableStore();
 				for (const providerDescriptor of extension.value) {
 					this.registerChatProvider(providerDescriptor);
-					const extensionIcon = extension.description.icon ?
-						resources.joinPath(extension.description.extensionLocation, extension.description.icon) :
-						undefined;
-					this._chatContributionService.registerChatProvider({
-						...providerDescriptor,
-						extensionIcon
-					});
+					this._chatContributionService.registerChatProvider(providerDescriptor);
 				}
 				this._registrationDisposables.set(extension.description.identifier.value, extensionDisposable);
 			}