Skip to content

Commit cf7b20b

Browse files
committed
cleanup property after running tests
1 parent 71deec3 commit cf7b20b

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

src/vs/editor/contrib/suggest/test/browser/suggestModel.test.ts

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ import { IWorkspaceContextService } from 'vs/platform/workspace/common/workspace
3838
import { LanguageFeaturesService } from 'vs/editor/common/services/languageFeaturesService';
3939
import { ILanguageFeaturesService } from 'vs/editor/common/services/languageFeatures';
4040
import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
41-
import { setSnippetSuggestSupport } from 'vs/editor/contrib/suggest/browser/suggest';
41+
import { getSnippetSuggestSupport, setSnippetSuggestSupport } from 'vs/editor/contrib/suggest/browser/suggest';
4242

4343

4444
function createMockEditor(model: TextModel, languageFeaturesService: ILanguageFeaturesService): ITestCodeEditor {
@@ -1128,7 +1128,7 @@ suite('SuggestModel - TriggerAndCancelOracle', function () {
11281128

11291129
test('Snippets gone from IntelliSense #173244', function () {
11301130

1131-
const old = setSnippetSuggestSupport({
1131+
const snippetProvider: CompletionItemProvider = {
11321132
provideCompletionItems(doc, pos, ctx) {
11331133
return {
11341134
suggestions: [{
@@ -1139,8 +1139,14 @@ suite('SuggestModel - TriggerAndCancelOracle', function () {
11391139
}]
11401140
};
11411141
}
1142-
});
1143-
disposables.add(toDisposable(() => old && setSnippetSuggestSupport(old)));
1142+
};
1143+
const old = setSnippetSuggestSupport(snippetProvider);
1144+
1145+
disposables.add(toDisposable(() => {
1146+
if (getSnippetSuggestSupport() === snippetProvider) {
1147+
setSnippetSuggestSupport(old);
1148+
}
1149+
}));
11441150

11451151
disposables.add(registry.register({ scheme: 'test' }, {
11461152
triggerCharacters: ['.'],

0 commit comments

Comments
 (0)