Skip to content

Commit cfd8c45

Browse files
committed
don't explicitly dispose of view
1 parent 72f9450 commit cfd8c45

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

src/vs/workbench/contrib/accessibility/browser/accessibleView.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -96,18 +96,15 @@ class AccessibleView extends Disposable {
9696
}
9797

9898
show(provider: IAccessibleContentProvider): void {
99-
let view: IDisposable | undefined;
10099
const delegate: IContextViewDelegate = {
101100
getAnchor: () => this._editorContainer,
102101
render: (container) => {
103-
view = this._render(provider, container);
104-
return view;
102+
return this._render(provider, container);
105103
},
106104
onHide: () => {
107105
if (provider.options.type === AccessibleViewType.HelpMenu) {
108106
this._accessiblityHelpIsShown.reset();
109107
}
110-
view?.dispose();
111108
}
112109
};
113110
this._contextViewService.showContextView(delegate);
@@ -163,7 +160,7 @@ class AccessibleView extends Disposable {
163160
}));
164161
disposableStore.add(this._editorWidget.onDidBlurEditorText(() => this._contextViewService.hideContextView()));
165162
disposableStore.add(this._editorWidget.onDidContentSizeChange(() => this._layout()));
166-
return disposableStore;
163+
return toDisposable(() => { disposableStore.dispose(); });
167164
}
168165

169166
private _layout(): void {

0 commit comments

Comments
 (0)