Skip to content

Commit d017077

Browse files
committed
cleaning the code
1 parent 18eb6fd commit d017077

File tree

1 file changed

+5
-11
lines changed

1 file changed

+5
-11
lines changed

src/vs/editor/contrib/hover/browser/contentHover.ts

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { coalesce } from 'vs/base/common/arrays';
99
import { CancellationToken } from 'vs/base/common/cancellation';
1010
import { KeyCode } from 'vs/base/common/keyCodes';
1111
import { Disposable, DisposableStore, toDisposable } from 'vs/base/common/lifecycle';
12-
import { ContentWidgetPositionPreference, IActiveCodeEditor, ICodeEditor, IContentWidgetPosition, IEditorMouseEvent, MouseTargetType } from 'vs/editor/browser/editorBrowser';
12+
import { ContentWidgetPositionPreference, IActiveCodeEditor, ICodeEditor, IEditorMouseEvent, MouseTargetType } from 'vs/editor/browser/editorBrowser';
1313
import { ConfigurationChangedEvent, EditorOption } from 'vs/editor/common/config/editorOptions';
1414
import { Position } from 'vs/editor/common/core/position';
1515
import { Range } from 'vs/editor/common/core/range';
@@ -689,14 +689,9 @@ export class ResizableHoverWidget extends MultiplePersistedSizeResizableContentW
689689

690690
private _updateContentsDomNodeMaxDimensions() {
691691
const persistedSize = this.findPersistedSize();
692-
if (!persistedSize) {
693-
this._setContentsDomNodeMaxDimensions(
694-
Math.max(this._editor.getLayoutInfo().width * 0.66, 500),
695-
Math.max(this._editor.getLayoutInfo().height / 4, 250));
696-
}
697-
else {
698-
this._setContentsDomNodeMaxDimensions('none', 'none');
699-
}
692+
const width = persistedSize ? 'none' : Math.max(this._editor.getLayoutInfo().width * 0.66, 500);
693+
const height = persistedSize ? 'none' : Math.max(this._editor.getLayoutInfo().height / 4, 250);
694+
this._setContentsDomNodeMaxDimensions(width, height);
700695
}
701696

702697
private _render(node: DocumentFragment, visibleData: ContentHoverData) {
@@ -716,13 +711,12 @@ export class ResizableHoverWidget extends MultiplePersistedSizeResizableContentW
716711
}
717712

718713
private _setContentPosition(visibleData: ContentHoverData, preference?: ContentWidgetPositionPreference) {
719-
const widgetPosition: IContentWidgetPosition = {
714+
this._contentPosition = {
720715
position: visibleData.showAtPosition,
721716
secondaryPosition: visibleData.showAtSecondaryPosition,
722717
positionAffinity: visibleData.isBeforeContent ? PositionAffinity.LeftOfInjectedText : undefined,
723718
preference: [preference ?? ContentWidgetPositionPreference.ABOVE]
724719
};
725-
this._contentPosition = widgetPosition;
726720
}
727721

728722
public showAt(node: DocumentFragment, visibleData: ContentHoverData): void {

0 commit comments

Comments
 (0)