Skip to content

Commit d050388

Browse files
authored
Remove unused disposable in template (microsoft#162271)
1 parent 261fc99 commit d050388

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

src/vs/base/browser/ui/selectBox/selectBoxCustom.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import { ISelectBoxDelegate, ISelectBoxOptions, ISelectBoxStyles, ISelectData, I
1515
import * as arrays from 'vs/base/common/arrays';
1616
import { Emitter, Event } from 'vs/base/common/event';
1717
import { KeyCode, KeyCodeUtils } from 'vs/base/common/keyCodes';
18-
import { Disposable, dispose, IDisposable } from 'vs/base/common/lifecycle';
18+
import { Disposable, IDisposable } from 'vs/base/common/lifecycle';
1919
import { isMacintosh } from 'vs/base/common/platform';
2020
import { ScrollbarVisibility } from 'vs/base/common/scrollable';
2121
import 'vs/css!./selectBoxCustom';
@@ -31,7 +31,6 @@ interface ISelectListTemplateData {
3131
text: HTMLElement;
3232
detail: HTMLElement;
3333
decoratorRight: HTMLElement;
34-
disposables: IDisposable[];
3534
}
3635

3736
class SelectListRenderer implements IListRenderer<ISelectOptionItem, ISelectListTemplateData> {
@@ -40,7 +39,6 @@ class SelectListRenderer implements IListRenderer<ISelectOptionItem, ISelectList
4039

4140
renderTemplate(container: HTMLElement): ISelectListTemplateData {
4241
const data: ISelectListTemplateData = Object.create(null);
43-
data.disposables = [];
4442
data.root = container;
4543
data.text = dom.append(container, $('.option-text'));
4644
data.detail = dom.append(container, $('.option-detail'));
@@ -71,8 +69,8 @@ class SelectListRenderer implements IListRenderer<ISelectOptionItem, ISelectList
7169
}
7270
}
7371

74-
disposeTemplate(templateData: ISelectListTemplateData): void {
75-
templateData.disposables = dispose(templateData.disposables);
72+
disposeTemplate(_templateData: ISelectListTemplateData): void {
73+
// noop
7674
}
7775
}
7876

0 commit comments

Comments
 (0)