Skip to content

Commit d21dee1

Browse files
authored
Merge pull request microsoft#205863 from microsoft/aiday/comparingBulkFileOperations
Show resources in multi diff editor and refactor preview in the same order
2 parents 801f963 + 2e99a31 commit d21dee1

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

src/vs/workbench/contrib/bulkEdit/browser/preview/bulkEditPane.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
import 'vs/css!./bulkEdit';
77
import { WorkbenchAsyncDataTree, IOpenEvent } from 'vs/platform/list/browser/listService';
8-
import { BulkEditElement, BulkEditDelegate, TextEditElementRenderer, FileElementRenderer, BulkEditDataSource, BulkEditIdentityProvider, FileElement, TextEditElement, BulkEditAccessibilityProvider, CategoryElementRenderer, BulkEditNaviLabelProvider, CategoryElement, BulkEditSorter } from 'vs/workbench/contrib/bulkEdit/browser/preview/bulkEditTree';
8+
import { BulkEditElement, BulkEditDelegate, TextEditElementRenderer, FileElementRenderer, BulkEditDataSource, BulkEditIdentityProvider, FileElement, TextEditElement, BulkEditAccessibilityProvider, CategoryElementRenderer, BulkEditNaviLabelProvider, CategoryElement, BulkEditSorter, compareBulkFileOperations } from 'vs/workbench/contrib/bulkEdit/browser/preview/bulkEditTree';
99
import { FuzzyScore } from 'vs/base/common/filters';
1010
import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
1111
import { IThemeService } from 'vs/platform/theme/common/themeService';
@@ -365,8 +365,9 @@ export class BulkEditPane extends ViewPane {
365365
if (this._fileOperations === fileOperations && this._resources) {
366366
return this._resources;
367367
}
368+
const sortedFileOperations = fileOperations.sort(compareBulkFileOperations);
368369
const resources: IResourceDiffEditorInput[] = [];
369-
for (const operation of fileOperations) {
370+
for (const operation of sortedFileOperations) {
370371
const operationUri = operation.uri;
371372
const previewUri = this._currentProvider!.asPreviewUri(operationUri);
372373
// delete -> show single editor

src/vs/workbench/contrib/bulkEdit/browser/preview/bulkEditTree.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,7 @@ export class BulkEditSorter implements ITreeSorter<BulkEditElement> {
286286

287287
compare(a: BulkEditElement, b: BulkEditElement): number {
288288
if (a instanceof FileElement && b instanceof FileElement) {
289-
return compare(a.edit.uri.toString(), b.edit.uri.toString());
289+
return compareBulkFileOperations(a.edit, b.edit);
290290
}
291291

292292
if (a instanceof TextEditElement && b instanceof TextEditElement) {
@@ -297,6 +297,10 @@ export class BulkEditSorter implements ITreeSorter<BulkEditElement> {
297297
}
298298
}
299299

300+
export function compareBulkFileOperations(a: BulkFileOperation, b: BulkFileOperation): number {
301+
return compare(a.uri.toString(), b.uri.toString());
302+
}
303+
300304
// --- ACCESSI
301305

302306
export class BulkEditAccessibilityProvider implements IListAccessibilityProvider<BulkEditElement> {

0 commit comments

Comments
 (0)