Skip to content

Commit d30b358

Browse files
authored
cli: ensure vscode server outlives CLI on windows (microsoft#210279)
1 parent a9174e5 commit d30b358

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

cli/src/tunnels/code_server.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -606,7 +606,9 @@ impl<'a> ServerBuilder<'a> {
606606
// Original issue: https://github.com/microsoft/vscode/issues/184058
607607
// Partial fix: https://github.com/microsoft/vscode/pull/184621
608608
#[cfg(target_os = "windows")]
609-
let cmd = cmd.creation_flags(winapi::um::winbase::CREATE_NO_WINDOW);
609+
let cmd = cmd.creation_flags(
610+
winapi::um::winbase::CREATE_NO_WINDOW | winapi::um::winbase::CREATE_NEW_PROCESS_GROUP | winapi::um::winbase::CREATE_BREAKAWAY_FROM_JOB,
611+
);
610612

611613
let child = cmd
612614
.stderr(std::process::Stdio::piped())

0 commit comments

Comments
 (0)