Skip to content

Commit d317fbf

Browse files
authored
chore: revert @vscode/spdlog bump (microsoft#179103)
* Revert "chore: update [email protected] (microsoft#179087)" This reverts commit 9eba21c. * Revert "Bump spdlog (microsoft#179035)" This reverts commit 4cc7f76.
1 parent 2836a92 commit d317fbf

File tree

8 files changed

+36
-36
lines changed

8 files changed

+36
-36
lines changed

.eslintrc.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,6 @@
222222
"@vscode/iconv-lite-umd",
223223
"@vscode/policy-watcher",
224224
"@vscode/proxy-agent",
225-
"@vscode/spdlog",
226225
"assert",
227226
"child_process",
228227
"console",
@@ -242,6 +241,7 @@
242241
"os",
243242
"path",
244243
"perf_hooks",
244+
"spdlog",
245245
"stream",
246246
"string_decoder",
247247
"tas-client-umd",

build/.moduleignore

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,6 @@ fsevents/src/**
1212
fsevents/test/**
1313
!fsevents/**/*.node
1414

15-
@vscode/spdlog/binding.gyp
16-
@vscode/spdlog/build/**
17-
@vscode/spdlog/deps/**
18-
@vscode/spdlog/src/**
19-
@vscode/spdlog/test/**
20-
@vscode/spdlog/*.yml
21-
!@vscode/spdlog/build/Release/*.node
22-
2315
@vscode/sqlite3/binding.gyp
2416
@vscode/sqlite3/benchmark/**
2517
@vscode/sqlite3/cloudformation/**
@@ -61,6 +53,14 @@ node-vsce-sign/**
6153
!node-vsce-sign/package.json
6254
!node-vsce-sign/bin/**
6355

56+
spdlog/binding.gyp
57+
spdlog/build/**
58+
spdlog/deps/**
59+
spdlog/src/**
60+
spdlog/test/**
61+
spdlog/*.yml
62+
!spdlog/build/Release/*.node
63+
6464
windows-foreground-love/binding.gyp
6565
windows-foreground-love/build/**
6666
windows-foreground-love/src/**

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@
6868
"@vscode/policy-watcher": "^1.1.4",
6969
"@vscode/proxy-agent": "^0.13.1",
7070
"@vscode/ripgrep": "^1.15.0",
71-
"@vscode/spdlog": "^0.13.9",
7271
"@vscode/sqlite3": "5.1.2-vscode",
7372
"@vscode/sudo-prompt": "9.3.1",
7473
"@vscode/vscode-languagedetection": "1.0.21",
@@ -82,6 +81,7 @@
8281
"native-keymap": "^3.3.2",
8382
"native-watchdog": "^1.4.1",
8483
"node-pty": "0.11.0-beta32",
84+
"spdlog": "^0.13.0",
8585
"tas-client-umd": "0.1.6",
8686
"v8-inspect-profiler": "^0.1.0",
8787
"vscode-oniguruma": "1.7.0",

remote/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
"@parcel/watcher": "2.1.0",
99
"@vscode/iconv-lite-umd": "0.7.0",
1010
"@vscode/proxy-agent": "^0.13.1",
11-
"@vscode/spdlog": "^0.13.9",
1211
"@vscode/ripgrep": "^1.15.0",
1312
"@vscode/vscode-languagedetection": "1.0.21",
1413
"cookie": "^0.4.0",
@@ -20,6 +19,7 @@
2019
"minimist": "^1.2.6",
2120
"native-watchdog": "^1.4.1",
2221
"node-pty": "0.11.0-beta32",
22+
"spdlog": "^0.13.0",
2323
"tas-client-umd": "0.1.6",
2424
"vscode-oniguruma": "1.7.0",
2525
"vscode-regexpp": "^3.1.0",

remote/yarn.lock

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -80,15 +80,6 @@
8080
https-proxy-agent "^5.0.0"
8181
proxy-from-env "^1.1.0"
8282

83-
"@vscode/spdlog@^0.13.9":
84-
version "0.13.9"
85-
resolved "https://registry.yarnpkg.com/@vscode/spdlog/-/spdlog-0.13.9.tgz#bac062762bc48ae9a6e86dd2d59c96b5ab63170c"
86-
integrity sha512-c5Kmkhq+FyI0tCr569Q9aqIex2CgfRsa41PirK/9zpGRYRJlPyLo5U3Vp3THvfJYiDDLpQFeyRh/Sy5UJFW2gA==
87-
dependencies:
88-
bindings "^1.5.0"
89-
mkdirp "^0.5.5"
90-
nan "^2.17.0"
91-
9283
9384
version "1.0.21"
9485
resolved "https://registry.yarnpkg.com/@vscode/vscode-languagedetection/-/vscode-languagedetection-1.0.21.tgz#89b48f293f6aa3341bb888c1118d16ff13b032d3"
@@ -706,6 +697,15 @@ socks@^2.3.3:
706697
ip "^1.1.5"
707698
smart-buffer "^4.1.0"
708699

700+
spdlog@^0.13.0:
701+
version "0.13.7"
702+
resolved "https://registry.yarnpkg.com/spdlog/-/spdlog-0.13.7.tgz#719a972be103e473770202e37dca1c9d80502180"
703+
integrity sha512-DiWxvyHuDJKfNuanSnizY2pmqZGaSHej3xpOD4LQ+kkT3oLWpCXI6VRFDnziyXBQKCl8kmyaYnOu9QBhf1WEXQ==
704+
dependencies:
705+
bindings "^1.5.0"
706+
mkdirp "^0.5.5"
707+
nan "^2.17.0"
708+
709709
string-width@^1.0.1:
710710
version "1.0.2"
711711
resolved "https://registry.yarnpkg.com/string-width/-/string-width-1.0.2.tgz#118bdf5b8cdc51a2a7e70d211e07e2b0b9b107d3"

src/vs/platform/environment/test/node/nativeModules.integrationTest.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,10 @@ flakySuite('Native Modules (all platforms)', () => {
4040
assert.ok(typeof nodePty.spawn === 'function', testErrorMessage('node-pty'));
4141
});
4242

43-
(process.type === 'renderer' ? test.skip /* TODO@electron module is not context aware yet and thus cannot load in Electron renderer used by tests */ : test)('@vscode/spdlog', async () => {
44-
const spdlog = await import('@vscode/spdlog');
45-
assert.ok(typeof spdlog.createRotatingLogger === 'function', testErrorMessage('@vscode/spdlog'));
46-
assert.ok(typeof spdlog.version === 'number', testErrorMessage('@vscode/spdlog'));
43+
(process.type === 'renderer' ? test.skip /* TODO@electron module is not context aware yet and thus cannot load in Electron renderer used by tests */ : test)('spdlog', async () => {
44+
const spdlog = await import('spdlog');
45+
assert.ok(typeof spdlog.createRotatingLogger === 'function', testErrorMessage('spdlog'));
46+
assert.ok(typeof spdlog.version === 'number', testErrorMessage('spdlog'));
4747
});
4848

4949
test('@parcel/watcher', async () => {

src/vs/platform/log/node/spdlogLog.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* Licensed under the MIT License. See License.txt in the project root for license information.
44
*--------------------------------------------------------------------------------------------*/
55

6-
import * as spdlog from '@vscode/spdlog';
6+
import * as spdlog from 'spdlog';
77
import { ByteSize } from 'vs/platform/files/common/files';
88
import { AbstractMessageLogger, ILogger, LogLevel } from 'vs/platform/log/common/log';
99

@@ -18,9 +18,9 @@ enum SpdLogLevel {
1818
}
1919

2020
async function createSpdLogLogger(name: string, logfilePath: string, filesize: number, filecount: number, donotUseFormatters: boolean): Promise<spdlog.Logger | null> {
21-
// Do not crash if @vscode/spdlog cannot be loaded
21+
// Do not crash if spdlog cannot be loaded
2222
try {
23-
const _spdlog = await import('@vscode/spdlog');
23+
const _spdlog = await import('spdlog');
2424
_spdlog.setFlushOn(SpdLogLevel.Trace);
2525
const logger = await _spdlog.createAsyncRotatingLogger(name, logfilePath, filesize, filecount);
2626
if (donotUseFormatters) {

yarn.lock

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1325,15 +1325,6 @@
13251325
https-proxy-agent "^5.0.0"
13261326
proxy-from-env "^1.1.0"
13271327

1328-
"@vscode/spdlog@^0.13.9":
1329-
version "0.13.9"
1330-
resolved "https://registry.yarnpkg.com/@vscode/spdlog/-/spdlog-0.13.9.tgz#bac062762bc48ae9a6e86dd2d59c96b5ab63170c"
1331-
integrity sha512-c5Kmkhq+FyI0tCr569Q9aqIex2CgfRsa41PirK/9zpGRYRJlPyLo5U3Vp3THvfJYiDDLpQFeyRh/Sy5UJFW2gA==
1332-
dependencies:
1333-
bindings "^1.5.0"
1334-
mkdirp "^0.5.5"
1335-
nan "^2.17.0"
1336-
13371328
13381329
version "5.1.2-vscode"
13391330
resolved "https://registry.yarnpkg.com/@vscode/sqlite3/-/sqlite3-5.1.2-vscode.tgz#ba15962d23ad784a43ecbaaa22c93f17f93b2400"
@@ -9379,6 +9370,15 @@ sparkles@^1.0.0:
93799370
resolved "https://registry.yarnpkg.com/sparkles/-/sparkles-1.0.1.tgz#008db65edce6c50eec0c5e228e1945061dd0437c"
93809371
integrity sha512-dSO0DDYUahUt/0/pD/Is3VIm5TGJjludZ0HVymmhYF6eNA53PVLhnUk0znSYbH8IYBuJdCE+1luR22jNLMaQdw==
93819372

9373+
spdlog@^0.13.0:
9374+
version "0.13.7"
9375+
resolved "https://registry.yarnpkg.com/spdlog/-/spdlog-0.13.7.tgz#719a972be103e473770202e37dca1c9d80502180"
9376+
integrity sha512-DiWxvyHuDJKfNuanSnizY2pmqZGaSHej3xpOD4LQ+kkT3oLWpCXI6VRFDnziyXBQKCl8kmyaYnOu9QBhf1WEXQ==
9377+
dependencies:
9378+
bindings "^1.5.0"
9379+
mkdirp "^0.5.5"
9380+
nan "^2.17.0"
9381+
93829382
spdx-correct@^3.0.0:
93839383
version "3.1.1"
93849384
resolved "https://registry.yarnpkg.com/spdx-correct/-/spdx-correct-3.1.1.tgz#dece81ac9c1e6713e5f7d1b6f17d468fa53d89a9"

0 commit comments

Comments
 (0)