add telemetry for clicking on sparkle (microsoft#203674)

add telemetry for clicking on sparke

Author: aeschli

src/vs/editor/contrib/codeAction/browser/codeAction.ts

@@ -245,7 +245,8 @@ function getDocumentationFromProvider(
 export enum ApplyCodeActionReason {
 	OnSave = 'onSave',
 	FromProblemsView = 'fromProblemsView',
-	FromCodeActions = 'fromCodeActions'
+	FromCodeActions = 'fromCodeActions',
+	FromAILightbulb = 'fromAILightbulb' // direct invocation when clicking on the AI lightbulb
 }
 
 export async function applyCodeAction(

src/vs/editor/contrib/codeAction/browser/codeActionController.ts

@@ -88,7 +88,7 @@ export class CodeActionController extends Disposable implements IEditorContribut
 		this._lightBulbWidget = new Lazy(() => {
 			const widget = this._editor.getContribution<LightBulbWidget>(LightBulbWidget.ID);
 			if (widget) {
-				this._register(widget.onClick(e => this.showCodeActionList(e.actions, e, { includeDisabledActions: false, fromLightbulb: true })));
+				this._register(widget.onClick(e => this.showCodeActionsFromLightbulb(e.actions, e)));
 			}
 			return widget;
 		});
@@ -103,6 +103,21 @@ export class CodeActionController extends Disposable implements IEditorContribut
 		super.dispose();
 	}
 
+	private async showCodeActionsFromLightbulb(actions: CodeActionSet, at: IAnchor | IPosition): Promise<void> {
+		if (actions.allAIFixes && actions.validActions.length === 1) {
+			const actionItem = actions.validActions[0];
+			const command = actionItem.action.command;
+			if (command && command.id === 'inlineChat.start') {
+				if (command.arguments && command.arguments.length >= 1) {
+					command.arguments[0] = { ...command.arguments[0], autoSend: false };
+				}
+			}
+			await this._applyCodeAction(actionItem, false, false, ApplyCodeActionReason.FromAILightbulb);
+			return;
+		}
+		await this.showCodeActionList(actions, at, { includeDisabledActions: false, fromLightbulb: true });
+	}
+
 	public showCodeActions(_trigger: CodeActionTrigger, actions: CodeActionSet, at: IAnchor | IPosition) {
 		return this.showCodeActionList(actions, at, { includeDisabledActions: false, fromLightbulb: false });
 	}
@@ -130,9 +145,9 @@ export class CodeActionController extends Disposable implements IEditorContribut
 		return this._model.trigger(trigger);
 	}
 
-	private async _applyCodeAction(action: CodeActionItem, retrigger: boolean, preview: boolean): Promise<void> {
+	private async _applyCodeAction(action: CodeActionItem, retrigger: boolean, preview: boolean, actionReason: ApplyCodeActionReason): Promise<void> {
 		try {
-			await this._instantiationService.invokeFunction(applyCodeAction, action, ApplyCodeActionReason.FromCodeActions, { preview, editor: this._editor });
+			await this._instantiationService.invokeFunction(applyCodeAction, action, actionReason, { preview, editor: this._editor });
 		} finally {
 			if (retrigger) {
 				this._trigger({ type: CodeActionTriggerType.Auto, triggerAction: CodeActionTriggerSource.QuickFix, filter: {} });
@@ -172,7 +187,7 @@ export class CodeActionController extends Disposable implements IEditorContribut
 				if (validActionToApply) {
 					try {
 						this._lightBulbWidget.value?.hide();
-						await this._applyCodeAction(validActionToApply, false, false);
+						await this._applyCodeAction(validActionToApply, false, false, ApplyCodeActionReason.FromCodeActions);
 					} finally {
 						actions.dispose();
 					}
@@ -264,7 +279,7 @@ export class CodeActionController extends Disposable implements IEditorContribut
 
 		const delegate: IActionListDelegate<CodeActionItem> = {
 			onSelect: async (action: CodeActionItem, preview?: boolean) => {
-				this._applyCodeAction(action, /* retrigger */ true, !!preview);
+				this._applyCodeAction(action, /* retrigger */ true, !!preview, ApplyCodeActionReason.FromCodeActions);
 				this._actionWidgetService.hide();
 				currentDecorations.clear();
 			},

src/vs/editor/contrib/codeAction/browser/lightBulbWidget.ts

@@ -86,22 +86,6 @@ export class LightBulbWidget extends Disposable implements IContentWidget {
 				return;
 			}
 
-			if (
-				this.state.actions.allAIFixes
-				&& this.state.actions.validActions.length === 1
-			) {
-				const action = this.state.actions.validActions[0].action;
-				const id = action.command?.id;
-				if (id) {
-					let args = action.command?.arguments;
-					if (id === 'inlineChat.start' && args && args.length === 1) {
-						args = [{ ...args[0], autoSend: false }];
-					}
-					commandService.executeCommand(id, ...(args || []));
-					e.preventDefault();
-					return;
-				}
-			}
 			// Make sure that focus / cursor location is not lost when clicking widget icon
 			this._editor.focus();
 			e.preventDefault();