Use const enum over const for search command IDs (microsoft#203757)

Fixes microsoft#190249

Author: andreamah

src/vs/workbench/contrib/search/browser/search.contribution.ts

@@ -121,7 +121,7 @@ quickAccessRegistry.registerQuickAccessProvider({
 	prefix: SymbolsQuickAccessProvider.PREFIX,
 	placeholder: nls.localize('symbolsQuickAccessPlaceholder', "Type the name of a symbol to open."),
 	contextKey: 'inWorkspaceSymbolsPicker',
-	helpEntries: [{ description: nls.localize('symbolsQuickAccess', "Go to Symbol in Workspace"), commandId: Constants.ShowAllSymbolsActionId }]
+	helpEntries: [{ description: nls.localize('symbolsQuickAccess', "Go to Symbol in Workspace"), commandId: Constants.SearchCommandIds.ShowAllSymbolsActionId }]
 });
 
 quickAccessRegistry.registerQuickAccessProvider({
@@ -132,7 +132,7 @@ quickAccessRegistry.registerQuickAccessProvider({
 	helpEntries: [
 		{
 			description: nls.localize('textSearchPickerHelp', "Search for Text (Experimental)"),
-			commandId: Constants.QuickTextSearchActionId,
+			commandId: Constants.SearchCommandIds.QuickTextSearchActionId,
 			commandCenterOrder: 65,
 		}
 	]

src/vs/workbench/contrib/search/browser/searchActionsCopy.ts

@@ -21,20 +21,20 @@ registerAction2(class CopyMatchCommandAction extends Action2 {
 	constructor(
 	) {
 		super({
-			id: Constants.CopyMatchCommandId,
+			id: Constants.SearchCommandIds.CopyMatchCommandId,
 			title: {
 				value: nls.localize('copyMatchLabel', "Copy"),
 				original: 'Copy'
 			},
 			category,
 			keybinding: {
 				weight: KeybindingWeight.WorkbenchContrib,
-				when: Constants.FileMatchOrMatchFocusKey,
+				when: Constants.SearchContext.FileMatchOrMatchFocusKey,
 				primary: KeyMod.CtrlCmd | KeyCode.KeyC,
 			},
 			menu: [{
 				id: MenuId.SearchContext,
-				when: Constants.FileMatchOrMatchFocusKey,
+				when: Constants.SearchContext.FileMatchOrMatchFocusKey,
 				group: 'search_2',
 				order: 1
 			}]
@@ -52,23 +52,23 @@ registerAction2(class CopyPathCommandAction extends Action2 {
 	constructor(
 	) {
 		super({
-			id: Constants.CopyPathCommandId,
+			id: Constants.SearchCommandIds.CopyPathCommandId,
 			title: {
 				value: nls.localize('copyPathLabel', "Copy Path"),
 				original: 'Copy Path'
 			},
 			category,
 			keybinding: {
 				weight: KeybindingWeight.WorkbenchContrib,
-				when: Constants.FileMatchOrFolderMatchWithResourceFocusKey,
+				when: Constants.SearchContext.FileMatchOrFolderMatchWithResourceFocusKey,
 				primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.KeyC,
 				win: {
 					primary: KeyMod.Shift | KeyMod.Alt | KeyCode.KeyC
 				},
 			},
 			menu: [{
 				id: MenuId.SearchContext,
-				when: Constants.FileMatchOrFolderMatchWithResourceFocusKey,
+				when: Constants.SearchContext.FileMatchOrFolderMatchWithResourceFocusKey,
 				group: 'search_2',
 				order: 2
 			}]
@@ -86,15 +86,15 @@ registerAction2(class CopyAllCommandAction extends Action2 {
 	constructor(
 	) {
 		super({
-			id: Constants.CopyAllCommandId,
+			id: Constants.SearchCommandIds.CopyAllCommandId,
 			title: {
 				value: nls.localize('copyAllLabel', "Copy All"),
 				original: 'Copy All'
 			},
 			category,
 			menu: [{
 				id: MenuId.SearchContext,
-				when: Constants.HasSearchResults,
+				when: Constants.SearchContext.HasSearchResults,
 				group: 'search_2',
 				order: 3
 			}]

src/vs/workbench/contrib/search/browser/searchActionsFind.ts

@@ -54,23 +54,23 @@ export interface IFindInFilesArgs {
 registerAction2(class RestrictSearchToFolderAction extends Action2 {
 	constructor() {
 		super({
-			id: Constants.RestrictSearchToFolderId,
+			id: Constants.SearchCommandIds.RestrictSearchToFolderId,
 			title: {
 				value: nls.localize('restrictResultsToFolder', "Restrict Search to Folder"),
 				original: 'Restrict Search to Folder'
 			},
 			category,
 			keybinding: {
 				weight: KeybindingWeight.WorkbenchContrib,
-				when: ContextKeyExpr.and(Constants.SearchViewVisibleKey, Constants.ResourceFolderFocusKey),
+				when: ContextKeyExpr.and(Constants.SearchContext.SearchViewVisibleKey, Constants.SearchContext.ResourceFolderFocusKey),
 				primary: KeyMod.Shift | KeyMod.Alt | KeyCode.KeyF,
 			},
 			menu: [
 				{
 					id: MenuId.SearchContext,
 					group: 'search',
 					order: 3,
-					when: ContextKeyExpr.and(Constants.ResourceFolderFocusKey)
+					when: ContextKeyExpr.and(Constants.SearchContext.ResourceFolderFocusKey)
 				}
 			]
 		});
@@ -83,7 +83,7 @@ registerAction2(class RestrictSearchToFolderAction extends Action2 {
 registerAction2(class ExcludeFolderFromSearchAction extends Action2 {
 	constructor() {
 		super({
-			id: Constants.ExcludeFolderFromSearchId,
+			id: Constants.SearchCommandIds.ExcludeFolderFromSearchId,
 			title: {
 				value: nls.localize('excludeFolderFromSearch', "Exclude Folder from Search"),
 				original: 'Exclude Folder from Search'
@@ -94,7 +94,7 @@ registerAction2(class ExcludeFolderFromSearchAction extends Action2 {
 					id: MenuId.SearchContext,
 					group: 'search',
 					order: 4,
-					when: ContextKeyExpr.and(Constants.ResourceFolderFocusKey)
+					when: ContextKeyExpr.and(Constants.SearchContext.ResourceFolderFocusKey)
 				}
 			]
 		});
@@ -109,15 +109,15 @@ registerAction2(class RevealInSideBarForSearchResultsAction extends Action2 {
 	constructor(
 	) {
 		super({
-			id: Constants.RevealInSideBarForSearchResults,
+			id: Constants.SearchCommandIds.RevealInSideBarForSearchResults,
 			title: {
 				value: nls.localize('revealInSideBar', "Reveal in Explorer View"),
 				original: 'Reveal in Explorer View'
 			},
 			category,
 			menu: [{
 				id: MenuId.SearchContext,
-				when: ContextKeyExpr.and(Constants.FileFocusKey, Constants.HasSearchResults),
+				when: ContextKeyExpr.and(Constants.SearchContext.FileFocusKey, Constants.SearchContext.HasSearchResults),
 				group: 'search_3',
 				order: 1
 			}]
@@ -167,7 +167,7 @@ registerAction2(class FindInFilesAction extends Action2 {
 	constructor(
 	) {
 		super({
-			id: Constants.FindInFilesActionId,
+			id: Constants.SearchCommandIds.FindInFilesActionId,
 			title: {
 				value: nls.localize('findInFiles', "Find in Files"),
 				mnemonicTitle: nls.localize({ key: 'miFindInFiles', comment: ['&& denotes a mnemonic'] }, "Find &&in Files"),
@@ -221,7 +221,7 @@ registerAction2(class FindInFolderAction extends Action2 {
 	// from explorer
 	constructor() {
 		super({
-			id: Constants.FindInFolderId,
+			id: Constants.SearchCommandIds.FindInFolderId,
 			title: {
 				value: nls.localize('findInFolder', "Find in Folder..."),
 				original: 'Find in Folder...'
@@ -251,7 +251,7 @@ registerAction2(class FindInWorkspaceAction extends Action2 {
 	// from explorer
 	constructor() {
 		super({
-			id: Constants.FindInWorkspaceId,
+			id: Constants.SearchCommandIds.FindInWorkspaceId,
 			title: {
 				value: nls.localize('findInWorkspace', "Find in Workspace..."),
 				original: 'Find in Workspace...'