Skip to content

Commit d7cc9b3

Browse files
CopilotTyriar
andcommitted
Fix compilation errors by implementing sendSignal method in missing classes
Co-authored-by: Tyriar <[email protected]>
1 parent ecad1e3 commit d7cc9b3

File tree

6 files changed

+33
-0
lines changed

6 files changed

+33
-0
lines changed

src/vs/platform/terminal/node/ptyHostService.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -248,6 +248,9 @@ export class PtyHostService extends Disposable implements IPtyHostService {
248248
input(id: number, data: string): Promise<void> {
249249
return this._proxy.input(id, data);
250250
}
251+
sendSignal(id: number, signal: string): Promise<void> {
252+
return this._proxy.sendSignal(id, signal);
253+
}
251254
processBinary(id: number, data: string): Promise<void> {
252255
return this._proxy.processBinary(id, data);
253256
}

src/vs/platform/terminal/node/ptyService.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -860,6 +860,12 @@ class PersistentTerminalProcess extends Disposable {
860860
}
861861
return this._terminalProcess.input(data);
862862
}
863+
sendSignal(signal: string): void {
864+
if (this._inReplay) {
865+
return;
866+
}
867+
return this._terminalProcess.sendSignal(signal);
868+
}
863869
writeBinary(data: string): Promise<void> {
864870
return this._terminalProcess.processBinary(data);
865871
}

src/vs/workbench/contrib/terminal/browser/remotePty.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,16 @@ export class RemotePty extends BasePty implements ITerminalChildProcess {
6565
});
6666
}
6767

68+
sendSignal(signal: string): void {
69+
if (this._inReplay) {
70+
return;
71+
}
72+
73+
this._startBarrier.wait().then(_ => {
74+
this._remoteTerminalChannel.sendSignal(this.id, signal);
75+
});
76+
}
77+
6878
processBinary(e: string): Promise<void> {
6979
return this._remoteTerminalChannel.processBinary(this.id, e);
7080
}

src/vs/workbench/contrib/terminal/browser/terminalProcessExtHostProxy.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,10 @@ export class TerminalProcessExtHostProxy extends Disposable implements ITerminal
120120
this._onInput.fire(data);
121121
}
122122

123+
sendSignal(signal: string): void {
124+
// No-op - Extension terminals don't have direct process access
125+
}
126+
123127
resize(cols: number, rows: number): void {
124128
this._onResize.fire({ cols, rows });
125129
}

src/vs/workbench/contrib/terminal/electron-sandbox/localPty.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,13 @@ export class LocalPty extends BasePty implements ITerminalChildProcess {
4545
this._proxy.input(this.id, data);
4646
}
4747

48+
sendSignal(signal: string): void {
49+
if (this._inReplay) {
50+
return;
51+
}
52+
this._proxy.sendSignal(this.id, signal);
53+
}
54+
4855
resize(cols: number, rows: number): void {
4956
if (this._inReplay || this._lastDimensions.cols === cols && this._lastDimensions.rows === rows) {
5057
return;

src/vs/workbench/services/terminal/common/embedderTerminalService.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,9 @@ class EmbedderTerminalProcess extends Disposable implements ITerminalChildProces
118118
input(): void {
119119
// not supported
120120
}
121+
sendSignal(): void {
122+
// not supported
123+
}
121124
async processBinary(): Promise<void> {
122125
// not supported
123126
}

0 commit comments

Comments
 (0)