fix: save walkthroughPageTitle in GettingStartedInput (microsoft#232169)

Author: bhavyaus

src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStarted.ts

@@ -907,6 +907,7 @@ export class GettingStartedPage extends EditorPane {
 					this.hasScrolledToFirstCategory = true;
 					this.currentWalkthrough = first;
 					this.editorInput.selectedCategory = this.currentWalkthrough?.id;
+					this.editorInput.walkthroughPageTitle = this.currentWalkthrough.walkthroughPageTitle;
 					this.buildCategorySlide(this.editorInput.selectedCategory, undefined);
 					this.setSlide('details', true /* firstLaunch */);
 					return;
@@ -1181,6 +1182,7 @@ export class GettingStartedPage extends EditorPane {
 			reset(this.stepsContent);
 			this.editorInput.selectedCategory = categoryID;
 			this.editorInput.selectedStep = stepId;
+			this.editorInput.walkthroughPageTitle = ourCategory.walkthroughPageTitle;
 			this.currentWalkthrough = ourCategory;
 			this.buildCategorySlide(categoryID, stepId);
 			this.setSlide('details');
@@ -1530,6 +1532,7 @@ export class GettingStartedPage extends EditorPane {
 				this.editorInput.selectedCategory = undefined;
 				this.editorInput.selectedStep = undefined;
 				this.editorInput.showTelemetryNotice = false;
+				this.editorInput.walkthroughPageTitle = undefined;
 
 				if (this.gettingStartedCategories.length !== this.gettingStartedList?.itemCount) {
 					// extensions may have changed in the time since we last displayed the walkthrough list
@@ -1612,9 +1615,9 @@ export class GettingStartedInputSerializer implements IEditorSerializer {
 		return instantiationService.invokeFunction(accessor => {
 			try {
 				const { selectedCategory, selectedStep } = JSON.parse(serializedEditorInput);
-				return new GettingStartedInput({ selectedCategory, selectedStep }, accessor.get(IWalkthroughsService));
+				return new GettingStartedInput({ selectedCategory, selectedStep });
 			} catch { }
-			return new GettingStartedInput({}, accessor.get(IWalkthroughsService));
+			return new GettingStartedInput({});
 
 		});
 	}

src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStartedInput.ts

@@ -10,12 +10,15 @@ import { URI } from '../../../../base/common/uri.js';
 import { Schemas } from '../../../../base/common/network.js';
 import { IUntypedEditorInput } from '../../../common/editor.js';
 import { IEditorOptions } from '../../../../platform/editor/common/editor.js';
-import { IWalkthroughsService } from './gettingStartedService.js';
 
 export const gettingStartedInputTypeId = 'workbench.editors.gettingStartedInput';
 
 export interface GettingStartedEditorOptions extends IEditorOptions {
-	selectedCategory?: string; selectedStep?: string; showTelemetryNotice?: boolean; showWelcome?: boolean;
+	selectedCategory?: string;
+	selectedStep?: string;
+	showTelemetryNotice?: boolean;
+	showWelcome?: boolean;
+	walkthroughPageTitle?: string;
 }
 
 export class GettingStartedInput extends EditorInput {
@@ -26,6 +29,7 @@ export class GettingStartedInput extends EditorInput {
 	private _selectedStep: string | undefined;
 	private _showTelemetryNotice: boolean;
 	private _showWelcome: boolean;
+	private _walkthroughPageTitle: string | undefined;
 
 	override get typeId(): string {
 		return GettingStartedInput.ID;
@@ -61,18 +65,17 @@ export class GettingStartedInput extends EditorInput {
 	}
 
 	constructor(
-		options: GettingStartedEditorOptions,
-		@IWalkthroughsService private readonly walkthroughService: IWalkthroughsService
-	) {
+		options: GettingStartedEditorOptions) {
 		super();
 		this._selectedCategory = options.selectedCategory;
 		this._selectedStep = options.selectedStep;
 		this._showTelemetryNotice = !!options.showTelemetryNotice;
 		this._showWelcome = options.showWelcome ?? true;
+		this._walkthroughPageTitle = options.walkthroughPageTitle;
 	}
 
 	override getName() {
-		return this.selectedCategory ? localize('walkthroughPageTitle', 'Walkthrough: ') + this.walkthroughService.getWalkthrough(this.selectedCategory).walkthroughPageTitle : localize('getStarted', "Welcome");
+		return this.walkthroughPageTitle ? localize('walkthroughPageTitle', 'Walkthrough: ') + this.walkthroughPageTitle : localize('getStarted', "Welcome");
 	}
 
 	get selectedCategory() {
@@ -107,4 +110,12 @@ export class GettingStartedInput extends EditorInput {
 	set showWelcome(value: boolean) {
 		this._showWelcome = value;
 	}
+
+	get walkthroughPageTitle(): string | undefined {
+		return this._walkthroughPageTitle;
+	}
+
+	set walkthroughPageTitle(value: string | undefined) {
+		this._walkthroughPageTitle = value;
+	}
 }