[Debt] Removing the useless contentHoverFocused IHoverState field (microsoft#209425)

removing the useless parameter

Author: aiday-mar

src/vs/editor/contrib/hover/browser/hover.ts

@@ -46,8 +46,6 @@ interface IHoverSettings {
 
 interface IHoverState {
 	mouseDown: boolean;
-	// TODO @aiday-mar maybe not needed, investigate this
-	contentHoverFocused: boolean;
 	activatedByDecoratorClick: boolean;
 }
 
@@ -66,7 +64,6 @@ export class HoverController extends Disposable implements IEditorContribution {
 	private _hoverSettings!: IHoverSettings;
 	private _hoverState: IHoverState = {
 		mouseDown: false,
-		contentHoverFocused: false,
 		activatedByDecoratorClick: false
 	};
 
@@ -146,7 +143,6 @@ export class HoverController extends Disposable implements IEditorContribution {
 
 		if (target.type === MouseTargetType.CONTENT_WIDGET && target.detail === ContentHoverWidget.ID) {
 			// mouse down on top of content hover widget
-			this._hoverState.contentHoverFocused = true;
 			return;
 		}
 
@@ -155,10 +151,6 @@ export class HoverController extends Disposable implements IEditorContribution {
 			return;
 		}
 
-		if (target.type !== MouseTargetType.OVERLAY_WIDGET) {
-			this._hoverState.contentHoverFocused = false;
-		}
-
 		if (this._contentWidget?.widget.isResizing) {
 			return;
 		}
@@ -232,9 +224,6 @@ export class HoverController extends Disposable implements IEditorContribution {
 		if (this._contentWidget?.isFocused || this._contentWidget?.isResizing) {
 			return;
 		}
-		if (this._hoverState.mouseDown && this._hoverState.contentHoverFocused) {
-			return;
-		}
 		const sticky = this._hoverSettings.sticky;
 		if (sticky && this._contentWidget?.isVisibleFromKeyboard) {
 			// Sticky mode is on and the hover has been shown via keyboard
@@ -348,18 +337,13 @@ export class HoverController extends Disposable implements IEditorContribution {
 		if (_sticky) {
 			return;
 		}
-		if (
-			(
-				this._hoverState.mouseDown
-				&& this._hoverState.contentHoverFocused
-				&& this._contentWidget?.isColorPickerVisible
-			)
-			|| InlineSuggestionHintsContentWidget.dropDownVisible
-		) {
+		if ((
+			this._hoverState.mouseDown
+			&& this._contentWidget?.isColorPickerVisible
+		) || InlineSuggestionHintsContentWidget.dropDownVisible) {
 			return;
 		}
 		this._hoverState.activatedByDecoratorClick = false;
-		this._hoverState.contentHoverFocused = false;
 		this._glyphWidget?.hide();
 		this._contentWidget?.hide();
 	}