ESM: revisit removeGlobalNodeModuleLookupPaths (fix microsoft#226042) (microsoft#226603)

Author: bpasero

src/bootstrap-fork.js

@@ -23,7 +23,7 @@ performance.mark('code/fork/start');
 configureCrashReporter();
 
 // Remove global paths from the node module lookup (node.js only)
-bootstrapNode.removeGlobalNodeModuleLookupPaths();
+bootstrapNode.removeGlobalNodeJsModuleLookupPaths();
 
 // Enable ASAR in our forked processes
 bootstrapNode.enableASARSupport();

src/bootstrap-node.js

@@ -110,13 +110,11 @@ module.exports.devInjectNodeModuleLookupPath = function (injectPath) {
 	// ESM-comment-end
 };
 
-module.exports.removeGlobalNodeModuleLookupPaths = function () {
+module.exports.removeGlobalNodeJsModuleLookupPaths = function () {
 	if (typeof process?.versions?.electron === 'string') {
 		return; // Electron disables global search paths in https://github.com/electron/electron/blob/3186c2f0efa92d275dc3d57b5a14a60ed3846b0e/shell/common/node_bindings.cc#L653
 	}
 
-	// TODO@esm this might not work anymore (https://github.com/microsoft/vscode/issues/226042)
-
 	const Module = require('module');
 	// @ts-ignore
 	const globalPaths = Module.globalPaths;
@@ -273,7 +271,7 @@ module.exports.fileUriFromPath = function (path, config) {
 
 // ESM-uncomment-begin
 // export const devInjectNodeModuleLookupPath = module.exports.devInjectNodeModuleLookupPath;
-// export const removeGlobalNodeModuleLookupPaths = module.exports.removeGlobalNodeModuleLookupPaths;
+// export const removeGlobalNodeJsModuleLookupPaths = module.exports.removeGlobalNodeJsModuleLookupPaths;
 // export const configurePortable = module.exports.configurePortable;
 // export const enableASARSupport = module.exports.enableASARSupport;
 // export const fileUriFromPath = module.exports.fileUriFromPath;